Code Monkey home page Code Monkey logo

Comments (4)

mbroadhead avatar mbroadhead commented on May 24, 2024 3

@kasperwandahl @whoami213
You could also just override the rendering of the exception in app/Exceptions/Handler.php:

use Spatie\WebhookClient\Exceptions\WebhookFailed;
 
/**
 * Register the exception handling callbacks for the application.
 *
 * @return void
 */
public function register()
{
    $this->renderable(function (WebhookFailed $e, $request) {
         if ($request->is('api/*') && $e->getMessage() == 'The signature is invalid.') {
             return response()->json(['message' => $e->getMessage()], 401);
         }
    });
}

from laravel-webhook-client.

freekmurze avatar freekmurze commented on May 24, 2024 1

Send a PR with tests, and I'll consider merging it in.

from laravel-webhook-client.

freekmurze avatar freekmurze commented on May 24, 2024

You could listen for the InvalidSignatureEvent and throw the exception you want there.

from laravel-webhook-client.

kasperwandahl avatar kasperwandahl commented on May 24, 2024

Hi @freekmurze I was just looking into this exact thing as a company I'm working with received the 500 Internal Server Error and pointed their fingers at me, when the issue was in their side not sending the signature. I think a 401 Unauthorized is a better response code as it's their input which fails to pass validation. Would you be willing to consider this change?

from laravel-webhook-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.