Comments (1)
Ok, I'm an idiot. I changed it to this and fixed it.
public function isValid(Request $request, WebhookConfig $config): bool
{
$signature = $request->header($config->signatureHeaderName);
if (! $signature) {
return false;
}
$signature = trim(str_replace("sha1=", "", $signature));
$signingSecret = $config->signingSecret;
if (empty($signingSecret)) {
throw WebhookFailed::signingSecretNotSet();
}
$computedSignature = hash_hmac('sha1', $request->getContent(), $signingSecret);
return hash_equals($signature, $computedSignature);
}
I didn't realize that github was hashing the entire contents even though your function clearly shows handling it that way. Closing this.
from laravel-webhook-client.
Related Issues (20)
- Unable to specify the number of seconds for jobs
- Return Errors like API json error response
- There are no commands defined in the "vendor" namespace. HOT 1
- is it possible to save only specfic fields of payload?
- vendor publish command is not working in Laravel 7 HOT 1
- syntax error vendor/spatie/laravel-webhook-client/src/WebhookClientServiceProvider.php:28
- Class "Spatie\WebhookClient\Jobs\ProcessWebhookJob" not found HOT 3
- Log rotation
- Couldn't install
- WebhookCall is losing information
- Attribute [webhook] does not exist.
- "Not a valid process webhook job class"
- Attribute [webhooks] does not exist. HOT 5
- Static analysis fails when custom Model is used
- QueryException HOT 2
- Migration published missing "down" function, causing migrate issues HOT 3
- Change error http response code HOT 1
- Webhook Model can't be overridden HOT 2
- Using the package without config, like use with spatie/laravel-stripe-webhooks
- Attribute [webhooks] does not exist.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-webhook-client.