Comments (6)
I'm looking at this now. This is a weird one, I'm trying to decipher the original Engineer's intent but I'll hopefully get an update here in not too long.
from arduino_boards.
@edspark great, I think this file was based on the SparkFun_SAMD21_Dev/variant.h however the RedBoard Turbo doesn't have the UART Serial pins present.
from arduino_boards.
Sorry for the delay. As you mentioned the Turbo did not have Serial pins defined, but did have Serial1 pins defined. To me, the inclusion of a Serial1 port implies that there's a Serial port. So I removed Serial1 in favor of Serial and removed the extern to Serial1. Documentation else where will have to be updated but this is more consistent with out other SAMD21 variants. Thanks @sandeepmistry!
from arduino_boards.
@edspark cool, thanks for making the change!
For greater sketch compatibility my preference would still be to have SerialUSB
mapped to Serial
and Serial1
be mapped to the physical pins (0, 1) like they are on the Arduino Leonardo and SAMD21 based MKR boards.
That said, I understand if the change you made in 72d571d is preferable for SparkFun.
from arduino_boards.
Sorry for the delay in the release but I'm glad I stepped away. I agree with you @sandeepmistry, so I went ahead and kept Serial1 as it was previously but commented out the troublesome extern
. In addition there are comments in the variant files stating that there are pins defined for Serial
, but that they're not physically available. Anyway, the changes were included in 1.8.6.
from arduino_boards.
Hi @edspark,
There's still one change that's missing, the Arduino MKR Zero has the following in the variant.h
file: https://github.com/arduino/ArduinoCore-samd/blob/master/variants/mkrzero/variant.h#L208-L209
// Alias Serial to SerialUSB
#define Serial SerialUSB
from arduino_boards.
Related Issues (20)
- Product Documentation HOT 2
- SAMD_21_Dev Variant.cpp RX led pin definition mistake
- Sparkfun nrf52 library missing HOT 2
- ESP-IDF Compatibility HOT 1
- Outdated Arduino cores
- LilyPad USB Plus - incorrect PWM definition
- Missing bootloader make configuration for Qwiic micro
- STM32 Cube Programmer (not found)
- RX_LED Doesn't Work
- Update arm-none-eabi-gcc for SAMD boards HOT 3
- Error downloading boards HOT 1
- SparkFun STM32 Boards Not Found HOT 7
- SoftwareSerial cause freezing on Pro Micro 3.3V 8MHz
- Duplicate flag in expression HOT 1
- 1.8.3 malformed SAMD custom board config breaks arduino-cli HOT 3
- SAMD21: Increase UART buffer size to 256 bytes (from 64 bytes) HOT 1
- Remove Artemis-based boards from definition file HOT 1
- ESP32 - wish you would sync up to current Espressif ESP32 release HOT 1
- SparkFun_SAMD51_MicroMod not included in SDU library
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arduino_boards.