User stream watching - audio source separation / stream window creation doesn't work about webcord HOT 6 CLOSED

When you watching stream from another user, app doesn't separate audio sources like in vanilla app (...)

I believe this is the same behavior like in browsers. I guess there might be the limitation of the Web Audio API (or whatever Discord uses, I haven't analyzed much of their JavaScript code, this would take ages for me to do that) so there's a limit of one stream per page (browser tab). It might be also the problem within the web version of the Discord itself that it has some issues with its implementation that is not present within the desktop app. In that case that's an upstream issue, either caused by the API limitation or wrong implementation. As I'm unable to fix that right now, I would flag this issue as a wontfix. I may fix that once I will know any way to overwrite the API which Discord is using and force it to separate the sink per audio source (but that may lead to issues and bugs IMO, imagine creating a separate sink for each audio file being played on the page, not only this make things a bit more complicated than they should be, but also may reset itself on next calls).

(...) and manipulations with in-app stream audio slider doesn't make effect.

You mean the output volume slider by the in-app stream audio slider? From my tests, these work fine for me.

When you pick option "open stream in another window", app try redirect and open source in system browser on page https://discord.com/popout, but stream doesn't opens

Thanks for pointing this functionality to me. WebCord already handles the URL redirection to new windows and redirects them to the default application (which is usually a browser) under some condition (the URL protocol needs to be considered as secure enough by WebCord – currently I've whitelisted https, sftp, mailto and tel protocols, which I believe are most commonly used). I may need to change that behavior, so pages with the same origin are opened as the popup windows, which may need from me some effort to do that. This may be a lower-priority task to me, there's a lot of features/issues I need to implement from now. For that reason, this issue still remains open to show my interest within it. Please stay patient and watch the changes within the code.

from webcord.

You mean the output volume slider by the in-app stream audio slider? From my tests, these work fine for me.

Yep. for me it look like app combined audio sources from stream and user to one, and user has main priority.

from webcord.

You mean the output volume slider by the in-app stream audio slider? From my tests, these work fine for me.

Yep. for me it look like app combined audio sources from stream and user to one, and user has main priority.

Oh, you mean by that stream audio recording does not work? Unfortunately, that's the Electron limitation, I believe application can't record both audio and single application window as it would just break. For the MacOS audio recording doesn't work at all. See Electron Docs for more information.

from webcord.

Not sure about that recording.
Detailed process:
When i just in voice chat, audio level regulation for different users works correctly
When another user starts app streaming and i join to watch, as i see, all sources combined to one

Audio level regulation for user works fine, audio level regulation for stream didn`t work - if i decrease output level for user, it also decreases audio level stream from that user, but regulation for stream from player frame doesn't take effect.

Also as i see, when i join to stream watching, all audio sources combined to one (from another users too) and regulation level for streamer changed level for all - not sure about this, need little more tests

If you mean recording as catch audiostream from my machine when i starts stream, yep, it didn't works too, but similar issue i has also on official app

from webcord.

UPD: checked now - no, sources not combined, just didn't work audio slider from stream frame.

changes just didnt,t make effect for me.

Seems like it problem of browser version - in firefox/chrome it didn't works too.
I think if you haven`t idea how to fix it in app, you can close issue or focus on separate stream windows part

from webcord.

Seems like it problem of browser version - in firefox/chrome it didn't works too.

Great to know that, I wondered if that could be just an Electron issue.

I think if you haven`t idea how to fix it in app, you can close issue or focus on separate stream windows part

Maybe I someday try to mitigate the Discord Web bugs and fix them to work properly – there are much more issues that it has when comparing to the Discord client, like global push-to-talk feature for instance (which is possible to achieve using Electron's Global keyboard shortcut API). But for now I need to focus on other features and bug fixing.

And I will close this issue once I'll fix Discord popups to work or open a separate issue for it.

from webcord.