Comments (5)
Thanks for the great feedback, I think we'll add the factions to the docs while we figure out how to handle endpoints that maybe shouldn't require a token.
from api-docs.
I was able to see the factions by going to https://api.spacetraders.io/v2/factions
from api-docs.
This may be a documentation issue. If the endpoint is documented with a playerFaction ENUM it is clear witch values are allowed.
The game documentation then should have basic player faction stats/description.
Edit:
This is already documented...
"description": "The faction you choose determines your headquarters.",
"enum": [
"COSMIC",
"VOID",
"GALACTIC",
"QUANTUM",
"DOMINION"
]
},
from api-docs.
Given that /factions
is available without auth, and now has an isRecruiting
field. I propose that we should change that enum to a string, and send an appropriate error based on the string given: 404 Not Found
for a faction not found and 403 Forbidden
for a faction that's not recruiting?
issue title could also use an update, at this point. (As we've established the factions endpoint does not require auth)
from api-docs.
This has been resolved with factions endpoint no longer being gated
from api-docs.
Related Issues (20)
- Inconsistency in OpenAPI spec HOT 1
- 500 when creating survey at X1-XA95-57213D HOT 5
- Better Dynamic Respone Generation HOT 1
- ShipRefineResponse Response Code Mismatch HOT 1
- ShipRefineResponse - tradeSymbol vs Symbol Mismatch HOT 1
- Status API resetDate description HOT 2
- 500 response on survey at X1-DN76-32104E HOT 5
- /game/loans missing from SpaceTraders.json HOT 2
- 500 from negotiateContract HOT 1
- ShipyardTransaction.shipSymbol is confusing HOT 4
- Fails to build with openapi-core
- 500 from /extract HOT 1
- Error when generating client library HOT 2
- Stoplight mock server returns data out of schema
- Why API blocks requests from Iran?
- Waypoint filter incorrect spec HOT 1
- "Getting Started" kinda unclear about how to buy ship HOT 1
- validation error for Faction headquarters
- shipMissingMountsError is defined 2 times
- Crew Quarters module comes twice HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api-docs.