Comments (7)
Hmm, interesting. I know I've checked full frame vs subarray simulations before using the same RA, Dec values and had sources show up where I expected. Maybe I was checking some special case or something. One of the things I want to work on when I get back is to add a proper testing module to the repo that uses Jenkins to automatically run tests each time the code is updated.
from mirage.
The only case I can think of that would work is a subarray where self.subarray_bounds[0] and self.subarray_bounds[1] are equal to zero. It happens that none of the NIRISS subarrays are of that sort in the DMS coordinates, although several of them are that way in the detector coordinates.
from mirage.
@bhilbert4 do you have a strong preference for Jenkins compared to Travis? I am using travis for https://github.com/spacetelescope/pysiaf and I could try to set it up for mirage.
Let me know.
from mirage.
I don't have any preference between Travis/Jenkins. I think output file sizes may be a problem for testing on github, although I'm not positive.
from mirage.
I just did a quick check for NIRISS and NIRCam. For NIRCam I made a full frame and a SUB160 exposure, both with RA, Dec set to (4., 45.), and both using a point source catalog with a single source at (4, 45). So I expect the source to show up at the reference location in each of the exposures, which it did.
Repeating the same thing for NIRISS, using full frame as well as NIS_AMI1 and NIS_AMI4, the source did not show up in the subarray exposures. Very strange. I'm trying to think what code NIRCam is using that NIRISS is not, or vice versa that would result in different behavior.
from mirage.
My test run of the code is still running hours later, so I am not sure what the problem is with the machine I am using. I really have to wait until i can ssh to witserv3 to look at this again. But the fix I posted before should still apply here so you might look at the self.subarray_bounds[0] and self.subaray_bounds[1] values for NIRCam as opposed to NIRISS to see if there is any difference. The SIAF files may be treating things differently for the two cases, although it is difficult for me to imagine why it would be so.
from mirage.
This has been fixed (although it seems to have reappeared when trying to use pysiaf to get the aperture information...). I am closing this issue.
from mirage.
Related Issues (20)
- Documentation typo in create_catalog
- Check for distorted PSFs within the PSF library file
- Remove mention of PAM from documentation HOT 1
- CRDS Error - NIRISS SOSS Exoplanet Notebook HOT 6
- Offset between 2D sersic object and PSF for convolution? HOT 2
- key error "designation" from create_catalog.for_proposal HOT 5
- Error in catalog_seed_image.py that crashes mirage HOT 2
- Error extracting reference files using downloader HOT 5
- Remove skip_grism from RTD
- MIRAGE sensitivity files: what wavelength binning? HOT 3
- Problem with create_catalog.for_proposal() HOT 5
- `ValueError` upon import when attempting reference file download HOT 2
- jwst_gtvt failure?
- Duplicate tests
- having trouble simulating an image for a NIRcam observation... HOT 13
- Crossmatch produces duplicates in `catalog_creation.get_all_catalogs()`
- Issue during blotting of user provided FITS for seed image HOT 1
- Update RTD galaxy catalog creation page
- Update niriss_subarrays.list
- catalog_seed_image.py , deprecated feature: numpy.int( <list> )
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mirage.