There are too many levels of forum replies in the UI about spacedecentral-network HOT 2 CLOSED

The problem is harder than I thought.

I initially thought it only was a CSS problem, but when I went deeper into the code I discovered a serious bug.

In my screenshot all sub-replies are actually nested within each other, but they are perfectly aligned in the 3rd level, so I would say the issue was fixed, but actually didn't make any changes...

The real problem is that all the sub-replies in my screenshot, were created without refreshing the page, so in the database they all were assigned as the 2nd level reply sub-replies, that is why they appear aligned. The field that is causing the problem is "replicable_id"

When I refresh the page and try to make, for example, another 4th level sub-reply to the 3rd level reply, then it goes to the right place and gets aligned correctly, with the 4th level indentation.

So this error must be fixed before trying to mess with nesting levels, because it could affect the actual stored data, as some sub-replies in the forum, may be currently pointing to wrong parent replies.

from spacedecentral-network.

I have reviewed every single reply in the forum and it seems the bug didn't affect any existent data, so there is no need to fix the current production database, I fixed the affected code and added some conditional css rules for 3rd level and higher replies, this was a UI, just visual issue, we should never alter the data to change things like this issue.

I also tried to assess if integrating a nested tree gem like ancestry would worth the effort, probably it will be useful to improve data structure and performance, but it may involve so many critical changes in the database structure so I think for the moment the changes proposed in my pull request just fix the problem without messing with sensitive areas of the code.

from spacedecentral-network.