Code Monkey home page Code Monkey logo

Comments (10)

damacus avatar damacus commented on May 21, 2024

might it be easier to to use the apt installer to deal with your custom apt package?

from java.

k9ert avatar k9ert commented on May 21, 2024

The apt-installer is stuck currently
https://github.com/agileorbit-cookbooks/java/pull/179

... and i'm not sure whether it will help me and works as expected. I'm happy to use it as soon as it is there and is usable for me.
However: The java-cookbook is a very central piece and it's used in a lot of other cookbooks, e.g. maven/jenkins and others.

As such, i would expect it to be as flexible as possible which includes the possibility to just move out of the way if needed.

from java.

erichelgeson avatar erichelgeson commented on May 21, 2024

Trying to understand what the nop would do in this case? Do you still want to use the alternatives and environment setting parts of this recipe? If so could you just call them directly, eg: java::set_attributes_from_version and java::set_java_home ? What I'm reading is you want to use the java cookbook but don't want it to do anything.

The Jenkins cookbook explicitly does not depend on this cookbook and is up to the user to make the decision on how Java should be installed (could be via this cookbook, or just package 'openjdk'). The mvn cookbook could follow that paradigm as well (maven and Jenkins are both java apps, and both are utilities intended to be used in wrapper cookbooks to function).

Honestly I may be missing what your saying too, help me understand.

from java.

k9ert avatar k9ert commented on May 21, 2024

The jenkins-cookbook indeed does not need to use the java-cookbook. However the maven-cookbook uses that in the wrong way and probably we don't know which other cookbooks do it the wrong way, too.

I agree that the issue should be fixed THERE in the first place, but it would be really helpful if this cookbook can somehow contribute to a workaround in the meantime which is less complex than:

  1. forking
  2. implementing the nop-recipe
  3. install a berkshelf-api in front of my chefserver
  4. berks install my version of the community-cookbook into my chefserver with a weird versionnumber (1.24.100 because 1.24.0-companyName is not possible)
  5. using that version in my wrapper-cookbooks

If you would accept that PR (which i need to improve before), then i can at least get rid of 1-4 until the maven-cookbook fixed it part of the story.

from java.

erichelgeson avatar erichelgeson commented on May 21, 2024

I think I understand you're point now (let me reiterate)

  • Other cookbooks you depend on depend on this cookbook
  • You are already managing java in your own way
  • Give you a node attribute to skip everything

That does make sense. Can you also open an issue with the maven recipe (referencing this issue) I opened an issue on the maven cookbook. I'll discuss this with the team and get back to you.

Thanks for helping me understand your use case.

from java.

k9ert avatar k9ert commented on May 21, 2024

Thank you very much, especially for the issue-creation at maven. I'm happy to recreate the PR again (which i screwed up in its first version because of chef-newbie), just let me know.

from java.

erichelgeson avatar erichelgeson commented on May 21, 2024

@k9ert Talking with the team and a few others we do not think the NOOP way is the to go. I've documented recommendations for depending on this recipe for other community cookbook maintainers and would be happy to create pull requests on other cookbooks if there are more out there.

from java.

k9ert avatar k9ert commented on May 21, 2024

The issue at the maven-cookbook, although almost one month old, has not yet even qualified:
sous-chefs/maven#41

I think this makes clear, where the pain is. I know that i'm not a first-level-customer but just a kind of-second-level customer but it would be quite helpful if other cookbooks are not that responsive than you are (thanks for your responsiveness), to have that noop-cookbook.

Is there a particular reason you want to avoid to implement it?

from java.

erichelgeson avatar erichelgeson commented on May 21, 2024

The reason is that this cookbooks purpose is to install java and configure it for you, making it so it does nothing is counter to its purpose.

The maven cookbook is just a few attributes fed to an ark resource and a template, may be simpler for you to fork that and maintain than this cookbook.

Since maven is under opscode-cookbooks I'll try to attend the next office hours to get it merged in.

Also you are a first-level-customer, anyone who uses this cookbook is!

from java.

lock avatar lock commented on May 21, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.