Code Monkey home page Code Monkey logo

Comments (4)

karmi avatar karmi commented on May 16, 2024

Ryan, could you post a (sanitized) data_bags/elasticsearch/aws.json so I understand the issue better?

from elasticsearch.

ryan-roemer avatar ryan-roemer commented on May 16, 2024

Here's an analogue to my data bag (I actually tweaked the attributes to use an encrypted databag):

{
  "id": "elasticsearch",
  "cloud": {
    "ec2": {
      "security_group": "SOMETHING"
    },
    "aws": {
      "secret_key": "SECRET",
      "access_key": "ACCESS"
    }
  }
}

As I do have an ES security group, but am not yet running an ES cluster. This produces a YAML config of:

  ec2.groups: SOMETHING

(without a 0-level indent member discovery) instead of:

discovery:
  type: SOMETHING
  ec2.groups: SOMETHING

which causes a YAML config error.

So, I think it's fair to say you just must have discovery set if you set ec2.groups, but it could be more permissive in case someone sets the cloud.ec2 and not discovery. Totally up to you, and once again -- thanks for the great cookbook and responsiveness to issues!

from elasticsearch.

karmi avatar karmi commented on May 16, 2024

Hello Ryan,

see f1fc6ef, I think it's fair to use full namespaces in the YAML file, which makes everything more resilient, and the readability does not suffer too much :)

from elasticsearch.

ryan-roemer avatar ryan-roemer commented on May 16, 2024

The full namespaces work well, and don't get in to tortured "if-this-then-that-but-not..." template conditionals. Great idea. Thanks!

from elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.