Broken attempted aws plugin installation by default about elasticsearch HOT 6 CLOSED

I believe this could be solved by d00113f in #75, thanks for the report!

I believe the cause of this plugin being installed by default is that the attributes/aws.rb sets a version for it though

Agreed!, this sounds like the cause for it.

from elasticsearch.

I tried out the branch from that pull request, but that didn't fix it. This change jeremyolliver@a5b0368 (ontop of the branch in #75) does get the aws plugin installing correctly when using the elasticsearch::plugins recipe without elasticsearch::aws by specifying the plugin as "elasticsearch/elasticsearch-cloud-aws" not just aws or elasticsearch-cloud-aws.

This is definitely an improvement, in that elasticsearch isn't restarted every chef run, but I think ideal would be that the aws plugin isn't installed by default, unless explicitly included. This could be accomplished by either moving the version in attributes/aws.rb out of the hash that the plugins recipe checks to install from (e.g. default.elasticsearch['aws']['plugin_version'] = '1.11.0'), or by moving the setting of that attribute to inside the recipe itself.

from elasticsearch.

I'll wait until 75 is merged in before submitting this change. In the mean time I may see about making that change that I mentioned

from elasticsearch.

This is definitely an improvement, in that elasticsearch isn't restarted every chef run, but I think ideal would be that the aws plugin isn't installed by default, unless explicitly included.

Absolutely right. The plugin shouldn't be installed when you don't include the recipe, and I think your suggestions are spot on. I'll try to process #75 as soon as possible.

from elasticsearch.

Hi, I think the attached commit solves the issue, thanks for the report!

from elasticsearch.

I believe so, thanks

from elasticsearch.