@patcon I've made it recently just in order to follow the recommendations from Chef how libraries should look like:
https://www.chef.io/blog/2014/03/12/writing-libraries-in-chef-cookbooks/
https://docs.chef.io/libraries.html
I was also inspired by examples from mysql , postgresql cookbooks.

Actually, these helpers methods are designed for usage in the same cookbook. There is no need to call merge_confluence_settings in wrapper cookbooks.

from confluence.

Actually, these helpers methods are designed for usage in the same cookbook. There is no need to call merge_confluence_settings in wrapper cookbooks.

heh. i beg to differ :) I am calling them in a wrapper cookbook (for manipulating config files, doing restore from backup, etc), which is totally reasonable, right? otherwise the node object might differ from the settings hash, and attributes in the wrapper wouldn't match the actual cookbook

from confluence.

For example, if I want to talk to the database in my wrapper cookbook, I need to recreate the logic in here, including loading the merged settings hash:
https://github.com/bflad/chef-confluence/blob/master/recipes/database.rb

I'd much rather replace all the repetition with DRYness:

# my_confluence/recipes/restore.rb
settings = Confluence.merge_confluence_settings

postgresql_database settings['database']['name'] do
  connection Confluence.database_connection
  owner settings['database']['user']
  action [:drop, :create]
end

Is this unreasonable?

from confluence.

I think it's reasonable that this cookbook provides external cookbooks a
method for retrieving the finished product of determining the settings just
like the cookbook internally uses so they don't have to reinvent the wheel.

On Wed, Sep 30, 2015, 16:31 Patrick Connolly [email protected]
wrote:

For example, if I want to talk to the database in my wrapper cookbook, I
need to recreate the logic in here, including loading the merged settings
hash:
https://github.com/bflad/chef-confluence/blob/master/recipes/database.rb

I'd much rather replace all the repetition with DRYness:

my_confluence/recipes/restore.rb

settings = Confluence.merge_confluence_settings

postgresql_database settings['database']['name'] do
connection Confluence.database_connection
owner settings['database']['user']
action [:drop, :create]end

Is this unreasonable?

—
Reply to this email directly or view it on GitHub
#55 (comment)
.

from confluence.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from confluence.