Code Monkey home page Code Monkey logo

Comments (1)

RootLUG avatar RootLUG commented on June 11, 2024

After diving into this problem I concluded that this is not worth implementing (atm) given possible problems vs speedup this will give for aura diff, my reasoning:

The diff (difflib.unified_diff) would need to be replaced with a re-implementation that would expose the line numbers of changed locations. This would cause a code duplication since it would basically be a copy-pasted code of the implementation from the stdlib. Aggregated numbers of changed lines should then be somehow exposed (ScanLocation.metadata?) so that the analyzers plugin (string finder/blob extractor) can read it and decide based on the changes. This is doable but will however break often due to the optimizations done by Aura.

Namely, this will break due to constant propagations. Consider there is a string defined which is later propagated by ast optimizations into some functions call (eval(x) for example). The function call receiving the string has not changed so the blob extraction would skip/ignore this but the code from which the constant originated has changed. This is just one of the potential scenarios where the diff can be (wrongly) ignored which is far worse (as the user relly on reporting the differences by aura) than the performance gain from skipping unchanged locations for blob extraction.

from aura.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.