Comments (1)
After diving into this problem I concluded that this is not worth implementing (atm) given possible problems vs speedup this will give for aura diff, my reasoning:
The diff (difflib.unified_diff) would need to be replaced with a re-implementation that would expose the line numbers of changed locations. This would cause a code duplication since it would basically be a copy-pasted code of the implementation from the stdlib. Aggregated numbers of changed lines should then be somehow exposed (ScanLocation.metadata?) so that the analyzers plugin (string finder/blob extractor) can read it and decide based on the changes. This is doable but will however break often due to the optimizations done by Aura.
Namely, this will break due to constant propagations. Consider there is a string defined which is later propagated by ast optimizations into some functions call (eval(x)
for example). The function call receiving the string has not changed so the blob extraction would skip/ignore this but the code from which the constant originated has changed. This is just one of the potential scenarios where the diff can be (wrongly) ignored which is far worse (as the user relly on reporting the differences by aura) than the performance gain from skipping unchanged locations for blob extraction.
from aura.
Related Issues (20)
- include update hooks for plugins/analyzers + extend yara signatures
- remove binwalk integration HOT 2
- An Issue with HTML Output HOT 2
- Problem Generating Report for PyPI Package faiss HOT 1
- Feature Request: Show Numeric Count of Detections by Type in Color-Coded Filter Section HOT 1
- Feature Request: Code Viewing Capability HOT 1
- Question related to scanning specific package version HOT 2
- Add analyzer to report non-ascii character
- Unable to run the application from a local directory in terminal HOT 2
- Regarding Taint Analysis Report in output file HOT 2
- Main file to run AURA HOT 1
- aura diff incorectly reports empty file
- Taint Analysis - Across file and class HOT 1
- About AST Construction HOT 1
- ValueError: current limit exceeds maximum limit HOT 6
- Tainted Sink in output
- Analyses Byte code(.pyc) or source code(.py)? HOT 1
- Does the project support value-level taint analysis? HOT 1
- Taking more time to analyse with many processes
- Add ClamAV integration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aura.