Code Monkey home page Code Monkey logo

Comments (3)

cheton avatar cheton commented on September 14, 2024

How about calling this.setState within componentWillReceiveProps?

@Sortable(options)
class SortableList extends React.Component {
    state = {
        items: this.props.items
    };
    componentWillReceiveProps(nextProps) {
        this.setState({ items: nextProps.items });
    }
    render() {
        :   :   :
    }
}

I can get it work with this example, and here is a demo.

from react-sortablejs.

kjanoudi avatar kjanoudi commented on September 14, 2024

@cheton that works if the render function always returns a list. However, in the event that the list of items is empty, in my use case, i am returning a message that says "This list has no items", and the render function never gets to the portion where a list is rendered. Perhaps this is a design flaw on my end by not extracting the sortable portion into it's own component?

Flipping back and forth between lists that have no items and lists that have some items results in sortable not working

render() {
        const { items } = this.state
        if (!items || !items.length) {
            return <p>There are no items in this category.</p>
        }

        return (
            <div>
                <ul ref="list" >
                    {items.map((i, k) =>
                        <li key={k} >
        ....
       )

from react-sortablejs.

cheton avatar cheton commented on September 14, 2024

I just realised what you have encountered. I will take a look at your PR and merge it soon. Thanks!

from react-sortablejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.