Comments (10)
tl;dr you can't have a http readiness probe checking for a redirect, it must get a 200 response.
So we should check for something else or not have one.
from charts.
I have removed the probe for now to stop the flapping, but I'll leave this open for now... maybe there's a sensible exec command to use instead.
from charts.
Hello ! I think we could use the mongo db health check I implemented : sorry-cypress/sorry-cypress#589
This way the director will be considered ready when the express server is listening and the connexion with MongoDB is working.
from charts.
This would (obviously) only be a solution if the user has chosen to use a mongodb though.
from charts.
Then I think we should just implement an API health check that respond a 200 if the API is running
from charts.
Is there really an option to not use a MongoDB though ? 🤔 Of course you can fork the project and implement a new ExecutionDriver but it means you rewrite almost half the codebase
from charts.
Ah yeh. It's still technically possible.. you just don't get an API.
And executionDriver: "../execution/in-memory"
is valid.
from charts.
The health check is not specific to the mongodb. Your execution driver must implement a isDbHealthy
method (which returns true immediately when you use the in-memory driver)
app.get('/health-check-db', catchRequestHandlerErrors(async (_, res) => { const executionDriver = await getExecutionDriver(); (await executionDriver.isDBHealthy()) ? res.sendStatus(200) : res.sendStatus(503); }) );
So I guess using this as a readyness probe can work. Or else we just write something like this :
app.get( '/health-check', (req, res) => { res.sendStatus(200); } );
from charts.
Sounds possible then. I probably can't get to this this week, will happily accept PRs :)
from charts.
Resoved by PR #134
from charts.
Related Issues (20)
- Missing s3 prefix env vars
- Internal mongo db does not recover on pod restarts
- Default dashboard deployment has GQL errors HOT 5
- Helm Chart giving Error when viewing the Dashboard HOT 6
- MinIO bundled chart does not support Ingress networking.k8s.io/v1 HOT 2
- Is the project dead? HOT 3
- Wrong screenshot driver recommended for s3 storage setup HOT 2
- Director service `ALLOWED_KEYS` environment variable
- Add `nodeSelector`s to `runCleaner` section
- it still counting execution time when run timed out HOT 1
- Minio port change HOT 1
- api.readinessProbe.enabled value does not exist. HOT 1
- Dashboard GraphQL endpoint shows 405 error on browser - can't load project list HOT 3
- s3 URL is wrong in sorry-cypress dashboard HOT 5
- Azure Blob Storage - Error: Unable to extract accountName with provided information. HOT 2
- Not able to see screenshot in azure storage account HOT 3
- It seem the last chart isn't on the latest version of sorry-cypress
- Not getting results shown in the dashboard HOT 2
- Use newer MinIO version
- Sorry-cypress Helm chart does not include a screenshot GCS driver
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from charts.