Oban crashes when Ecto logging is disabled about oban HOT 5 CLOSED

Are you able to replicate this with a simple Ecto query where you specify log: false? Oban isn't doing anything fancy with the verbose value, it is passing it through as log: true or log: false for each query.

from oban.

@sorentwo we can replicate this with:

Ecto.Adapters.SQL.query!(Testapp.Repo, "SELECT 1 AS one", [], log: true)

The log: true matches the defaults from Oban.Config

from oban.

On a side one, if we supply a log level, instead of true, the query is logged as expected, overriding the repo config:

Keyword.get(Testapp.Repo.config(), :log)
# false
Ecto.Adapters.SQL.query!(Testapp.Repo, "SELECT 1 AS one", [], log: :info)
# [info] QUERY OK db=0.4ms queue=0.7ms
# SELECT 1 AS one []

The documentation on Ecto.Repo has the following to say about the :log option:

the log level used when logging the query with Elixir's Logger. If false, disables 
logging for that repository. Defaults to :debug

Is never explicitly said to support true (like verbose does here), so maybe oban should follow the same semantics of "log_level or false" instead of being either "true and false"?

from oban.

@lucasmazza Thanks gain. Pushed a patch that prevents this from happening, and encourages a more sensible default.

from oban.

@sorentwo thanks for the always fast and focused patches ❤️

from oban.