First deploy: start the application without the migrations about oban HOT 7 CLOSED

@philss Thanks for reporting the issue. I admit, I haven't used the new release task yet and hadn't ran into this.

I'll work on instructions for avoiding this issue, and possibly make some changes to prevent it from happening entirely. My goal is to have as few manual steps for users as possible—the project should feel like it "Just Works", and crashing on initial boot definitely isn't "just working".

from oban.

@sorentwo Thank you for the clarification. The commit you mentioned seems to mitigate the problem. I will try this soon.

from oban.

@philss That was only a partial solution, I plan on writing some release specific deployment docs as well.

Currently I'm debating between two alternative solutions:

1. Catch failing queries from the producer and log them as errors rather than crashing the process. This would prevent the queue supervisor from crashing, which would prevent the cascade that can bring down the system.
2. Document that for the initial deployment Oban should not be started, or at the very least queues must be disabled. That seems like a bit of a hack and puts the burden of sequential deploys on developers.

I'm leaning heavily toward the first option and calling it "resilient" mode. It would be the default mode, which could be disabled if you'd prefer to have a crash.

Thoughts?

from oban.

@sorentwo the 1st option seems to be a good approach - oban could check if the expected table exists, log that the database needs to be migrated and sleep for a few minutes, so the system can recover if the table is created right away. This mechanism could help future upgrades that require database changes and people might not noticed it when updating the dependency.

from oban.

@sorentwo I like the approach of the 1st option, and like @lucasmazza suggested, it could check if the database is ready to run jobs and log the errors if not.

from oban.

The first option is in master and will be in v0.4 that I'm about to release. There is a small blurb about it in the README and a bit more detail in the CHANGELOG under [Oban.Queue.Producer].

Thanks again for the report. Hopefully this improves the deployment process for everybody as more and more people move to use releases.

from oban.

@sorentwo awesome! Thank you!

from oban.