Code Monkey home page Code Monkey logo

Comments (9)

sonburn avatar sonburn commented on June 15, 2024

@ivanbachev I am having a hard time reproducing any issue of the wrong symbol being swapped. Is this something you are able to reproduce consistently?

I'll see what I can do about the dropdown, I was trying to solve an issue where symbol names were being cutoff if longer than the dropdown.

from symbol-swapper.

ivanbachev avatar ivanbachev commented on June 15, 2024

Sure, here is a quick screencast to show the bug:
https://www.dropbox.com/s/kpqi962cocm6p1z/Symbol%20Swapper%200.20%20-%20bug.mov?dl=0

say I have an instance of a library symbol named:
“button / 01 primary / default / 01 text / 01 enabled”

and I want to swap it with:
“button / 02 secondary / default / 01 text / 01 enabled”

what happens instead is that the Symbol Swapper plugin incorrectly identifies the symbol as:
“button / 01 primary / default / 02 text and icon / 03 active”

and replaces it with:
“button / 01 primary / small / 02 text and icon / 04 focus”

Hope this helps.

from symbol-swapper.

ivanbachev avatar ivanbachev commented on June 15, 2024

As a comparison, see a screencast taken with v 0.19 (downloaded from the GitHub commits) - where the above flow works fine -
https://www.dropbox.com/s/tkess1uxb8q0x4i/Symbol%20Swapper%200.19%20-%20ok.mov?dl=0

from symbol-swapper.

ivanbachev avatar ivanbachev commented on June 15, 2024

The pattern I noticed is that in the v 0.20 example, Symbol Swapper incorrectly shows the current symbol instance name matching the symbol that is +7 positions in the list of all library symbols.
Then it swaps it with a symbol that is -7 positions next to the actually selected symbol for replacement.

from symbol-swapper.

jrapert avatar jrapert commented on June 15, 2024

Was this ever resolved? I'm having the same issue

from symbol-swapper.

jorgemartins avatar jorgemartins commented on June 15, 2024

on way to go around this is to select the wrong option X number of steps from the right one
for example to get the "secondary enabled", you choose de "secondary active":
Screenshot 2020-04-29 at 14 05 08

from symbol-swapper.

sonburn avatar sonburn commented on June 15, 2024

@ivanbachev, @jorgemartins, Apologies, there was an issue with the last version, which I finally got a chance to resolve. Could you please try version 0.21 which I just published?

from symbol-swapper.

jorgemartins avatar jorgemartins commented on June 15, 2024

I can confirm that so far it is working as intended. Also the new scrollable dropdown instead of the select box 👍
thanks for the quick turn around.

from symbol-swapper.

sonburn avatar sonburn commented on June 15, 2024

The issue had to do with missing and disabled libraries not being removed from the list of available libraries, this is why the results were offset at times, or other times the plugin would fail. Version 0.21 was a step in the right direction but there was still another issue which I have resolved in 0.22.

from symbol-swapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.