Comments (9)
@ivanbachev I am having a hard time reproducing any issue of the wrong symbol being swapped. Is this something you are able to reproduce consistently?
I'll see what I can do about the dropdown, I was trying to solve an issue where symbol names were being cutoff if longer than the dropdown.
from symbol-swapper.
Sure, here is a quick screencast to show the bug:
https://www.dropbox.com/s/kpqi962cocm6p1z/Symbol%20Swapper%200.20%20-%20bug.mov?dl=0
say I have an instance of a library symbol named:
“button / 01 primary / default / 01 text / 01 enabled”
and I want to swap it with:
“button / 02 secondary / default / 01 text / 01 enabled”
what happens instead is that the Symbol Swapper plugin incorrectly identifies the symbol as:
“button / 01 primary / default / 02 text and icon / 03 active”
and replaces it with:
“button / 01 primary / small / 02 text and icon / 04 focus”
Hope this helps.
from symbol-swapper.
As a comparison, see a screencast taken with v 0.19 (downloaded from the GitHub commits) - where the above flow works fine -
https://www.dropbox.com/s/tkess1uxb8q0x4i/Symbol%20Swapper%200.19%20-%20ok.mov?dl=0
from symbol-swapper.
The pattern I noticed is that in the v 0.20 example, Symbol Swapper incorrectly shows the current symbol instance name matching the symbol that is +7 positions in the list of all library symbols.
Then it swaps it with a symbol that is -7 positions next to the actually selected symbol for replacement.
from symbol-swapper.
Was this ever resolved? I'm having the same issue
from symbol-swapper.
on way to go around this is to select the wrong option X number of steps from the right one
for example to get the "secondary enabled", you choose de "secondary active":
from symbol-swapper.
@ivanbachev, @jorgemartins, Apologies, there was an issue with the last version, which I finally got a chance to resolve. Could you please try version 0.21 which I just published?
from symbol-swapper.
I can confirm that so far it is working as intended. Also the new scrollable dropdown instead of the select box 👍
thanks for the quick turn around.
from symbol-swapper.
The issue had to do with missing and disabled libraries not being removed from the list of available libraries, this is why the results were offset at times, or other times the plugin would fail. Version 0.21 was a step in the right direction but there was still another issue which I have resolved in 0.22.
from symbol-swapper.
Related Issues (20)
- Works only once HOT 3
- 'Let me choose' option uses the wrong symbol HOT 4
- Symbols not correct on swap HOT 2
- No "Current Document" in dropdown list to when swapping libraries.
- Create Inventory Page adds all symbols from all libraries
- Dialog not large enough on macOS Big Sur HOT 1
- Crashing on Apple Silicon / M1 Chip Macs HOT 1
- Can't scroll all the way down HOT 3
- Crashing on "Symbol swap selections"
- Scrollview does not go till the end of the list
- Feature request - Swapping nested symbols
- Compatibility issues with Sketch 72 HOT 1
- Not working in Sketch Version 72.1 (124357) HOT 1
- Scrolling Issue on v72 HOT 2
- The list of symbols is too narrow for symbols with longer names HOT 1
- Swap Libraries: Unable to scroll to last library on the list HOT 1
- Problems with Abstract library swapping
- All crashing in Sketch 85
- Blank Screens in Sketch 96 HOT 4
- Can the exchange instance maintain the original variable of the instance?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from symbol-swapper.