Code Monkey home page Code Monkey logo

Comments (13)

rvanlaak avatar rvanlaak commented on May 18, 2024

+1

from entityauditbundle.

andrewtch avatar andrewtch commented on May 18, 2024

I've been thinking about metadata storage, that would allow storing of tags too, but please provide a code sample on how you imagine that.

from entityauditbundle.

rvanlaak avatar rvanlaak commented on May 18, 2024

What for code sample do you mean? Something like a scenario how to use use this feature?

We'd like to 'mark' an order to a certain tag

  1. when it was paid by a customer,
  2. when the order was completed

It also would be nice if this could work in combination with Symfony's built-in ACL, so something like a PRE_FLUSH Doctrine listener that can make use of those tags/metadata.

from entityauditbundle.

andrewtch avatar andrewtch commented on May 18, 2024

I was discussing something like that with my colleague before, but we couldn't find a solutions other than

$entity = $repos->find();
$entity->setValue('new value');
$auditManager->attachRevisionmetadata($entity, array('source' => 'xml'));

$em->flush();

which is a very generic way actually. Do you have a better idea?

from entityauditbundle.

rvanlaak avatar rvanlaak commented on May 18, 2024

Don't exactly understand what you're trying to archieve with the code sample you gave. I would expect the $auditManager to have a function like addTag($auditableEntity, $tagName=null) with $tagName as an optional parameter.

If I'm right this could be implemented by adding an extra column to the central revisions table, and adding a function to the manager to getEntityByTag($auditableEntity).

The built-in Bundle views could show the tags in an extra column.

from entityauditbundle.

andrewtch avatar andrewtch commented on May 18, 2024

Ah, you mean tagging existing revisions after these revisions are saved? I'm talking about attaching arbitrary metadata to entities before flash, which is a more generic way. Which approach suits you most?

from entityauditbundle.

rvanlaak avatar rvanlaak commented on May 18, 2024

Adding metadata (like a tag/name) to the current Unit-of-Work indeed does sound better, as long as the metadata will be unique and it will be possible to get an entity based on a metadata key.

from entityauditbundle.

andrewtch avatar andrewtch commented on May 18, 2024

Uh-huh. We'll try to mix up something next week.

How do you think is better - adding metas to current revision or per-entity?

from entityauditbundle.

rvanlaak avatar rvanlaak commented on May 18, 2024

You mean the target table for the metadata? I would add it to the revisions table, since it is possible for Doctrine to search in Array types. Tried to find documentation about it, but couldn't find it that fast.

from entityauditbundle.

andrewtch avatar andrewtch commented on May 18, 2024

I'm thinking about what is better - having a metadata bag for a revision or having an option to add metas to concrete entity.

Array is not much an option - I started hacking EntityAudit since we have to upgrade old project where history audit tables ar ~5m records long (it's a CMS with ~ 5000 pages and ~ 5 years of work).

from entityauditbundle.

andrewtch avatar andrewtch commented on May 18, 2024

Well, it looks like we need to have something like:

  • AuditManager->addRevisionMeta($key, $value)
  • AuditManager->addEntityMeta(object $entity, $key, $value)

that is persisted in OnFlush and also the following methods:

  • Revision->getRevisionMeta
  • ChangedEntity->getRevisionMeta
  • AuditReader->findRevisionByMeta($key, $value);

@DavidBadura , what do you think?

from entityauditbundle.

OskarStark avatar OskarStark commented on May 18, 2024

great idea!

from entityauditbundle.

github-actions avatar github-actions commented on May 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from entityauditbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.