Code Monkey home page Code Monkey logo

Comments (48)

markus101 avatar markus101 commented on July 28, 2024 10

Parsing of files (and storing them in the DB) has been merged in. Importing and renaming files will come in future releases, we want to ensure the parsing is working properly first.

from sonarr.

markus101 avatar markus101 commented on July 28, 2024 1

Thanks for reporting @Waseh I found the cause and pushed a fix for it, it'll be in the next build.

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from martinohansen on Trello:

Looking forward to this!

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from dr_dre on Trello:

if subtitles download isnt implemented this is a nice 2nd as i could use other tools to download together with client.

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from fubduck on Trello:

I have used an nzbget postprocessing script to download the subtitles. I just need them moved with the video file to the correct folder otherwise nzbdrone ignores them when doing the renaming process and they get deleted.

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from arnaudjezequel1 on Trello:

Yes .srt files move would be great :)

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from markus101 on Trello:

Not being actively worked on, so moving it back.

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from bertgt on Trello:

It'd be great if you could specify a list of file extensions to include in the rename process, rather than have hard-coded file extensions.
eg. Settings > Media Management > File Management (heading)
List of file extensions to include in move process (separate with a comma)
[avi, mkv, mp4 ...... sub, srt, idx]

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from evtk on Trello:

Let have this idea to also conclude to 'delete additional files'.

When I download another (better) quality, NzbDrone automatically removes the old version. But I would like it to have delete also the additional files (like *.srt).

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from youphulsebos1 on Trello:

I wanted to start working on the subtitle card. But @Taloth asked me to work on this one first. To make sure I get what this card means. The following should be made:

  • Create setting to opt in for moving extra files (mayby a default for subtitle files)
  • Moving files from the download location (if its present)
  • Rename the files accordingly with the episode name
  • Keep the file names up to date if the episode is renamed.

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from zignature on Trello:

perhaps add an optional filter list for extensions just like in Sickbeard so you could optionally limit to certain files to be moved

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from achillespdx on Trello:

Yea, the filter list for extensions would be great. I don't need most of the crap that comes along with a download like samples and jpgs and nfo files, but subtitles are important.

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from zoggy on Trello:

the way this was implemented in sb is that all files with the same 'base' name as the original file get moved "move associated files". thus filename.en.srt would get moved not just filename with different extensions. then i added the ability to filter out said files, where the user can specify a list of extensions of stuff to keep. Filter associated files by specific non-media file extensions (separated with coma). (eg. .idx, .sub, .en.srt)

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from taloth on Trello:

@youphulsebos1 The criteria that makes this card really difficult is that we want every file tracked in the MetadataFile table. Which means adding quite some code to insert and update entries.
Months ago I worked on the 'import' side, scanning the files and associating them with the video file. I probably have some code on my fork, but it's heavily outdated.
The part I got stuck on was the metadataFile table stuff. At the same time another important feature came around (CDH and torrent support) and we moved the whole thing back to the backlog.

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from christopher324 on Trello:

Please allow the user to specify files extensions to be moved. Also have an option to move all files(for specified extensions) regardless of the base name. Currently Sick Beard and Sick Rage only "Move Associated Files" when the file base name matches that of the main video file. There are times when .nfo and other files have different names and SB and SR ignore/delete these.

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from mpnico on Trello:

I love keeping scene .nfo with my episodes. Since Episode folder is available, this card is my next must have that i miss from SB.

from sonarr.

SonarrBot avatar SonarrBot commented on July 28, 2024

Comment from sakuj0 on Trello:

I for one am a fan of having a directory structure like this:
TV/SeriesName/Season ##/EpisodeNameRenamed/originalfile1.mkv
originalfile2.srt, originalfile3.srr, originalfile4.nfo etc.

That keeps things perfectly organized without getting rid off the information that is the original file name. Renaming a file name into something more organized always increases entropy as information is destroyed. Wrapping the desired name structure into a folder name does not.

Mainly a lot of people want to keep all common extra files that come with a download, except for maybe url files, downloaded_by_demonoid or whatever files probably got added by someone other than the original release group.

Priority is not getting rid off .sub files or .srt files, of course - not the extra I mentioned above. That is really what counts. Imagine watching something like Lilyhammer without subtitles for the native parts. Of course release groups should mux them and set them as a forced subtitle stream but that is sadly not always the case. And subtitles in extra languages often come extra, people often choose better trackers because release groups there include all those extra subtitles etc.

from sonarr.

tutipeti avatar tutipeti commented on July 28, 2024

Any idea when this will be implemented? I'd like to fix my whole library to use the same naming convention everywhere, but I really don't want to rename every single subtitle file manually one by one..

from sonarr.

Caleb-C avatar Caleb-C commented on July 28, 2024

I agree, @tutipeti! I love to explore TV shows in different languages (and accents) and find subtitles invaluable. If I knew C# or had the time to pick it up, I would attack this one myself. Instead of just moving the media file, it should not be a big change to move all additional files with the same name (different extension) to the same location (enabled via a setting). This should happen when renaming existing library files or moving new files into the library.

I request, with great respect to the sacrifice of time invested by those who contribute, to address this enhancement soon.

from sonarr.

Taloth avatar Taloth commented on July 28, 2024

Hey folks, tnx for taking the time to reply.

Contrary to popular believe this isn't an easy feature to do 'right'.
One requirement we have is that all files must be tracked in the database (this has the added advantage that it makes implementing subtitle downloading easier in the future, coz we would know which subs are already covered). So the 'move/rename base-file' trick won't satisfy that.
One might argue 'something is better than nothing', well... here's another: 'if it's worth doing, it worth doing right.' 😉

Also, the fact that xbmckodi and plex support subtitle downloading hasn't exactly made this a priority.
But that doesn't mean it's a zombie issue that never gets implemented, in fact, just a couple of weeks ago I had a chat with @markus101 about some architectural implications.
I just can't tell you when we get around to it.

from sonarr.

Enf0 avatar Enf0 commented on July 28, 2024

The problem with having Plex (or similar tools like Subliminal) download subtitles later is that they usually guess which subtitle is the correct one for the specific release. In my experience, I often end up with out-of-sync subtitles.
The subtitles that are attached to the release is always the correct subtitles for that file.

Hoping this issue is still being looked into, it would be great to have!

from sonarr.

upmg avatar upmg commented on July 28, 2024

So is this going to happen? its the only thing stopping me moving from Sickbeard to Sonarr.

from sonarr.

Caleb-C avatar Caleb-C commented on July 28, 2024

+1 !! I wish this was implemented. I cannot tell you how much time I spend moving the subtitles over to their destination. Its not as simple as it seems because I have different shows on different drives (its the perfect job for a program that knows where my shows are located).

I disagree that these files would need to be tracked in order to determine which shows have subtitles. If subtitle-downloading is implemented, it will almost certainly be done when the files are moved to their destination (or when downloading). Therefore, if the subtitle is present at that time, then do not download it. I do not see an advantage of keeping track of these files once at their destination (except for being able to delete them -- though this can easily be handled with an option to delete files of the same name but different extension). Also, please keep in mind that sometimes there are several subtitle files per show (multiple languages).

from sonarr.

tutipeti avatar tutipeti commented on July 28, 2024

+1 by me too, would love to see this finally.

from sonarr.

upmg avatar upmg commented on July 28, 2024

All I need is the files not to be deleted, and renamed and moved along with the original file. If the subtitle is not present in the download I do not expect Sonarr to have to find it for me.

from sonarr.

Caleb-C avatar Caleb-C commented on July 28, 2024

Is it possible to do this with a custom script? To do this, the script would need access to the source path (including file name) and destination path.

from sonarr.

bwh avatar bwh commented on July 28, 2024

It's the year 2015 and I can't believe I'm adding my support to additional file renaming, since the functionality is not present still. :)

Seriously though, I've been using Sonarr for a long while and find it great, I tried other alternatives in the past years, but Sonarr seems the best to me. I never had the need to rename files since my downloader took care of it and my subtitle downloader mimics the file name.

Today I renamed the files with Sonarr, I ended up with lots of files with real different names (mkv vs srt).

If you can't add this feature soon, please at least ADD A WARNING, that only what's shown on the screen will be renamed, since many people would believe it would rename related files as well... Or an UNDO might be also lifesaving at this point.

from sonarr.

upmg avatar upmg commented on July 28, 2024

Completely agree bwh, I keep checking back to see if this has been implemented yet.

Some people want Sonarr to download the subs, I just want Sonarr not to get rid of them and rename them along with the shows filename/episode format.

We live in hope.

from sonarr.

dingsbums avatar dingsbums commented on July 28, 2024

it's almost 2016 now and still no support for moving additional files :(

+1

from sonarr.

vmsteve avatar vmsteve commented on July 28, 2024

+1. I have a family member with profound hearing loss and subtitles are a necessity. I hope someone will take this on it could help a lot of people. It really is more than a feature it's a necessity for many. I just need the renaming part other programs can take care of the downloading of subtitles.

from sonarr.

liiight avatar liiight commented on July 28, 2024

As a developer myself, I understand the argument @Taloth made with regards to doing it right. That being said, it's a highly requested feature for a really long time.

Not to hijack this issue, but as a contributor to Flexget I can offer a solution for this (using Flexget).
Using this config file with Flexget will allow using sonarr as an input for shows:

tasks:
  sonarr_task:
    configure_series:
      from:
        sonarr::
          base_url: '<host>'
          port: 8531
          api_key: '<api_key>'
          include_ended: false
          only_monitored: true
          include_data: yes
    rss: <url>
    deluge: yes
    move:
      to: "/filestorage2/{{series_name}}/"
      filename: '{{ series_name }} - {{ series_id }}{{ location|pathext }}'
      along:
        - sub
        - srt

This is just an example obviously, but using something like this would enable using Flexget alongside sonarr.

from sonarr.

rosskinard avatar rosskinard commented on July 28, 2024

+1

After moving from SickRage to Sonarr I'm way more impressed with Sonarr and its options, but my dismay at finding all my subtitle file orphaned after the Organize was pretty big. Thousands of IDX, SUB and SRT files left and my only option is to manually rename and move them to match how Sonarr renamed the video files.

from sonarr.

guillaume86 avatar guillaume86 commented on July 28, 2024

@Taloth The problem you describe seems more related to downloading subtitles that are not provided with the release. For the OP issue, maybe I'm missing something, but what about a simple option like:

"Extensions to rename with episode": ".en.srt, .srt"

I don't think it requires storing the information somewhere else, just query that option everytime an episode is renamed and apply to files matching the previous episode name.

from sonarr.

valantislevas avatar valantislevas commented on July 28, 2024

so when copy/move/rename/import extra files like .srt will be available? i saw that is fixed in develop branch?

from sonarr.

tutipeti avatar tutipeti commented on July 28, 2024

@valantislevas where did you see it on develop? As far as I see the PR #1046 is still open.

from sonarr.

seertenedos avatar seertenedos commented on July 28, 2024

wow this has been open since 2013 and you still have not worked out how to move the subtitle files when you move the video files and to rename them. That is quite an important feature especially for shows in other languages.

from sonarr.

pdf avatar pdf commented on July 28, 2024

@seertenedos if you just take look at the issue history, you can see that @markus101 has been working on this on-and-off for the last few months, so progress is definitely being made, and we can hope that this feature will land sometime in the not-too-distant future.

from sonarr.

seertenedos avatar seertenedos commented on July 28, 2024

@pdf valid point and thanks @markus101 for working on this. I am doing this manually at the minute using FileBot. Sonarr is such a great app and i have been using it for years but i never realised this was missing as most of the subs i got were embedded. Really looking forward to this being completed

from sonarr.

haudankaivajasi avatar haudankaivajasi commented on July 28, 2024

Hey. What is the situation of this?

from sonarr.

casperse avatar casperse commented on July 28, 2024

So Sonarr will still delete all my subtitles (Would be happy just to get them moved to the renemed folder)
Can anyone confirm if its true that sickrage can do this? (Need country subtitles)

from sonarr.

valantislevas avatar valantislevas commented on July 28, 2024

yes i use sickrage only for post proccessing the series (rename/move).. untill sonarr is able to do

from sonarr.

casperse avatar casperse commented on July 28, 2024

I have played around with both, and why not just use sickrage for everything? (Here I can also create a filter pr tv show, and not as in Sonarr one filter "words" for all? Please help me understand what sonarr can do better (I am just now testing them all, and would like some input) Thanks

from sonarr.

markus101 avatar markus101 commented on July 28, 2024

Please keep this thread on topic, if you wish to discuss the differences there are better mediums.

from sonarr.

Waseh avatar Waseh commented on July 28, 2024

@markus101
So i just tested this with a couple of files and im getting filenames that are missing a dot (".")
Instead of "file.1080p.en.srt" i get "file.1080p.ensrt", and instead of "file.1080p.nfo-orig" i get "file.1080pnfo-orig"
Have i setup something wrong or is there an issue with the renaming?

from sonarr.

valantislevas avatar valantislevas commented on July 28, 2024

when we can use that feature on master repo? @markus101

from sonarr.

markus101 avatar markus101 commented on July 28, 2024

We can't provide an ETA, we've been fixing a few things with it, but it shouldn't be too much longer.

from sonarr.

tenzion avatar tenzion commented on July 28, 2024

Really looking forward to this feature!

from sonarr.

sim099 avatar sim099 commented on July 28, 2024

This feature doesn't seem to work for me, at least not for nfo files. I enabled it straight after the latest update was applied and forgotten about it. Going back and checking now, my custom script that simply copies extra files into another directory has nfo files for the last few that I've imported. I've checked the last few episodes in the target directory (i.e. my NAS drive) and none of them have "nfo-orig" files. I haven't imported anything with subtitles since then though, so can't say if it's just nfo files or not.

I have "Import Extra Files" set to "Yes" and "Extra File Extensions" to "srt,sub,idx,nfo". Is this correct? Wasn't entirely sure whether to include the full stops, but ended up going by the example from the tooltip of the help icon, which is "sub,nfo".

Is there any other settings that I may not have configured correctly?

from sonarr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.