Comments (7)
Thank you for the detailed explanation. I have nothing against the proposal in general as long as it's not one of those implementations that litter the home folder or pull in dependencies through language specific package managers like pip that the system has no way of knowing about. Build systems are totally unexplored turf for me from a developer's point of view, and I have no time for the learning curve atm, so if you're willing to implement this, I'll merge or give you write access, whichever works best for you.
from morewaita.
I can do it if you like. But the theme related stuff would have to be moved into a subdir for easy integration with meson. It can be done without moving anything but then when you add new types of icons (e.g. mime types were added recently), meson.build
file will have to be modified to accommodate that change.
However, if we do move the theme into its own directory, meson.build
will probably never need to be changed again except of course when changing version number or renaming the sub-directory.
After moving, the directory structure should look something like
MoreWaita/
├── .github/
├── icons/
│ ├── apps/
│ ├── apps@2x -> apps/
│ ├── mimes/
│ ├── mimes@2x -> mimes/
│ ├── panel/
│ ├── panel@2x -> panel/
│ ├── places/
│ ├── places@2x -> places/
│ ├── status/
│ ├── status@2x -> status/
│ └── index.theme
├── AUTHORS
├── LICENSE
├── meson.build
└── README.md
from morewaita.
Sorry! Upon further investigation, I found out that meson does not support installing a subdir with its symlinks intact. It copies their targets instead. But we want to keep the symlinks intact.
So, there is no need to move stuff and any change in directory structure (e.g. adding a new category of icons) will always require modifying meson.build
file.
from morewaita.
I personally don't mind having to change meson configuration all the time. What we benefit from it is a standardized installation method and the downside would be having to add a few lines to the meson config every time a new icon is added. If it's documented properly, I think anyone could be able to do it. I'll try to write a first draft this weekend if that's fine by everyone.
from morewaita.
the downside would be having to add a few lines to the meson config every time a new icon is added.
So if I create a new icon and a handful of symlinks to it I'll have to manually add each new filename to the meson config, right? In my workflow I push new icons to GitHub and then update my actual installation through the AUR to test, and I'd like to be able to keep doing that.
from morewaita.
In my workflow I push new icons to GitHub and then update my actual installation through the AUR to test, and I'd like to be able to keep doing that.
Those steps in your workflow wouldn't change. You will only have to insert filenames and links into the meson specification after adding the icons and before pulling from aur.
Again, that would make no difference to the user but to a package maintainer it would standardize a packaging process.
from morewaita.
Then I have no objections.
I'm already doing it with my local .html file that I use to make the icon screenshot with all the icons.
Let me know what I can do to help.
from morewaita.
Related Issues (20)
- Icon request: QGIS
- Icon request: Typescript HOT 1
- Icon request: MediathekView
- Icon request: ProtonMail Import-Export app
- Icon request: foot
- Icon request: Linux QQ
- Icon request: Wireshark
- Icon request: GTKTerm
- Icon request: VIA
- Icon request: DeaDBeeF
- Icon request: Mercury Browser
- Icon request: Cider (Apple Music)
- Icon request: ClassiCube
- Icon request: R mime
- Icon request: .ipynb (jupyter notebook) mime
- Icon request: CSV (& TSV etc.) files mime
- Pamac icon is the same as Gnome Software HOT 2
- Some mime icons stopped working since Gnome 46 HOT 4
- Icon request: NetBeans
- Icon request: Logseq
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from morewaita.