Code Monkey home page Code Monkey logo

Comments (5)

SeinopSys avatar SeinopSys commented on June 23, 2024 1

I believe the current implementation of easing does not provide the correct arguments for the custom easing function, this is one of the things I tried to address in my PR #40. If you need custom easing support right now I suggest trying out my fork of this package, @seinopsys-forks/react-scrollchor, otherwise you can wait until the PR is accepted.

from react-scrollchor.

bySabi avatar bySabi commented on June 23, 2024 1

@joshuatuscan @SeinopSys sorry for the delay!

What I did, for the "deprecated" implementation, was copy and paste the easing function from here: https://github.com/danro/jquery-easing/blob/master/jquery.easing.js although that no longer matters because @SeinopSys has improved it a lot

Version 7.0.0 of this package had bee release with @SeinopSys PR's who did a wonderful job cleaning this module.

Now it seems that everything is in its place.

from react-scrollchor.

joshuatuscan avatar joshuatuscan commented on June 23, 2024

I think it'd be a great idea to make the default easing be something a little more straightforward, less opinionated, something like (easeOutSine)[https://easings.net/#easeOutSine].

For now tho, it would be great to just get an example of how to format for say Linear easing so that it can be passed through the Animation property and work with current code.

from react-scrollchor.

SeinopSys avatar SeinopSys commented on June 23, 2024

I honestly have no clue what sort of arcane magic is powering the implementation in its current form, I know I specifically adjusted my fork because I could not figure this out and wanted to use a more "standard" approach. The PR has sources for two basic easings here: https://github.com/SeinopSys/react-scrollchor/blob/v7/src/easing.ts

These are basically taken verbatim from the jQuery easing library and I'm confident you could plug any of the other easings from it in there and it will work.

from react-scrollchor.

bySabi avatar bySabi commented on June 23, 2024

I thiks is already solved.

Feel free to reopen it if needed

from react-scrollchor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.