Excluding-Problems about lsyncd HOT 9 CLOSED

Hi,

Maybe this is of use.

http://linux.byexamples.com/archives/305/filter-what-to-backup-with-rsync/

I have the same problem. Using the default rsync --exclude-from 
exclude-files.txt
works perfect, using lsyncd --exclude-from exclude-files.txt it seams to be 
ignored.
Any idea why?

System:
fedora 11 
lsyncd 1.26

Hi,
I took a shoot at the source looking for the cause of the problem, and I found 
out
that when passing the arguments to rsync the dir_conf->exclude_file is always 
equals
to NULL. I don't know the cause of this problem but a quick workaround is to 
force
the dir_conf->exclude_file to the file path and it works. This is not a 
permanent
solution to the problem. If and when I have the time I will try to find the 
cause of
the problem, should be a small mistake.

System:
fedora 11 
lsyncd 1.26

Best regards,
NP

Hi again,

Here is my suggestion for a simple fix, in lsyncd.c  line 665 and 669 replace
"dir_conf->exclude_file"  for  "default_exclude_file" and it should work fine.

System:
fedora 11 
lsyncd 1.26

Best regards,
NP

To  npissarra,

I exchange the lsyncd.c in line 665 and 669,but it doesn't work fine.
linux centos 5.4


Michael Field

It appears that lsyncd is not properly passing the --exclude-from to rsync, 
while my
C is rusty, here's a quick patch that works:


--- lsyncd-1.26/lsyncd.c        2009-01-05 06:39:41.000000000 -0700
+++ lsyncd-1.26.new/lsyncd.c    2010-03-31 13:58:16.000000000 -0700
@@ -662,11 +662,14 @@
                case CO_EXCLUDE :
                    // --exclude-from and the exclude file
                    // insert only when the exclude file is present otherwise skip it.
-                       if (dir_conf->exclude_file == NULL) {
+                       if (default_exclude_file == NULL) {
                                continue;
                        }
                        argv[argc++] = s_strdup("--exclude-from");
-                       argv[argc++] = s_strdup(dir_conf->exclude_file);
+                       argv[argc++] = s_strdup(default_exclude_file);
t (debug 2)");
                        continue;
                case CO_SOURCE :
                        argv[argc++] = s_strdup(src);

I suppose this was fixed with 1.33?

Looks like excludeFrom nor exclude in Lua configuration file don't work in 
2.0.1.
I haven't tested in older versions.
Can you please confirm it's a bug ?
Thanks.

Since if this is sure a new bug as the code base changed completly since 1.33. 
Please open a new bug with more details, what is your exclude file, and what is 
your config file.