Comments (4)
To improve the status quo, this line https://github.com/solidjs/solid-start/blob/main/packages/start/components/Outlet.tsx#L22 could be extended to let temp = list.find(o => o._id !== '/' && o._id && id.startsWith(o._id));
. This would make it possible to support this kind of file structure:
/account/registration.jsx
/account/registration/index.jsx
/account/registration/otherpage.jsx
That generates this route structure:
<Routes>
<Route path="/account/registration" element=..>
<Route path="/" element=.. >
<Route path="/" />
<Route path="/otherpage" element=.. />
</Route>
</Route>
</Routes>
Compared to the previous route structure that doesn't work at all:
<Routes>
<Route path="/account/registration" element=..>
<Route path="/" element=.. >
<Route path="/">
<Route path="/otherpage" element=.. />
</Route>
</Route>
</Route>
</Routes>
from solid-start.
I think the route structure should be ideally:
<Routes>
<Route path="/account/registration" element=..>
<Route path="/" element=.. />
<Route path="/otherpage" element=.. />
</Route>
</Routes>
There is no need for an intermediate slash path.. technically in this example only the top route is the shared layout.
from solid-start.
Oh yes, you're right. The patch produces exactly that route
from solid-start.
Could you take a look at it and merge it to main/release it?
from solid-start.
Related Issues (20)
- [Bug?]: <HttpStatusCode> doesn't work in mode:async HOT 2
- [Bug?]: unclosed-tags inside of innerHTML result in hydration mismatch HOT 2
- [Bug?] The response ignores multi-valued headers HOT 1
- [Ecosystem CI]: Integration in the vite-ecosystem-ci HOT 1
- [Bug?]: Erroneous 404s when rapidly switching routes HOT 3
- [Feature?]: I would like to be enable to pass a router before ssr, so any microframework (backend) can be bridged HOT 2
- [Bug?]: No route matched for preloading js assets HOT 6
- [Bug?]: createResource() throws "Hydration Mismatch" errors on page load HOT 1
- How to create a SSG site? HOT 4
- [Bug?]: Middleware with returned undici response ignores the content-type if the response body is async. HOT 3
- [Bug?]: client only doesn't work anymore for `props.children` HOT 6
- [Bug?]: Catch-all that starts with number after ellipsis in filename causes hydration errors in nested paths on dev HOT 1
- [Bug?]: Latest Vinxi (>= 0.3.11) causes layout shifts in dev HOT 4
- [Feature?]: Error Handling with solid-router HOT 8
- [Bug?]: Vite server config is being ignored HOT 4
- [Bug?]: Namespaces are completely stripped out of code HOT 4
- [Bug?]: error while importing module, related to `.` in path-name HOT 1
- [Bug?]: createHandler context only called once, renders nonce useless HOT 1
- [Bug?]: Client Only component displayed in app.tsx causes hydration errors HOT 1
- [Bug?]: No value attribute on CSR, but present in SSR HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solid-start.