Code Monkey home page Code Monkey logo

Comments (4)

jceb avatar jceb commented on May 18, 2024

To improve the status quo, this line https://github.com/solidjs/solid-start/blob/main/packages/start/components/Outlet.tsx#L22 could be extended to let temp = list.find(o => o._id !== '/' && o._id && id.startsWith(o._id));. This would make it possible to support this kind of file structure:

/account/registration.jsx
/account/registration/index.jsx
/account/registration/otherpage.jsx

That generates this route structure:

      <Routes>
        <Route path="/account/registration" element=..>
          <Route path="/" element=.. >
            <Route path="/" />
            <Route path="/otherpage" element=.. />
          </Route>
        </Route>
      </Routes>

Compared to the previous route structure that doesn't work at all:

      <Routes>
        <Route path="/account/registration" element=..>
          <Route path="/" element=.. >
            <Route path="/">
              <Route path="/otherpage" element=.. />
            </Route>
          </Route>
        </Route>
      </Routes>

from solid-start.

ryansolid avatar ryansolid commented on May 18, 2024

I think the route structure should be ideally:

<Routes>
  <Route path="/account/registration" element=..>
    <Route path="/" element=.. />
    <Route path="/otherpage" element=.. />
  </Route>
</Routes>

There is no need for an intermediate slash path.. technically in this example only the top route is the shared layout.

from solid-start.

jceb avatar jceb commented on May 18, 2024

Oh yes, you're right. The patch produces exactly that route

from solid-start.

jceb avatar jceb commented on May 18, 2024

Could you take a look at it and merge it to main/release it?

from solid-start.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.