Code Monkey home page Code Monkey logo

Comments (22)

sohobloo avatar sohobloo commented on July 29, 2024 4

@ajonno @DanAndreasson
Available now via npm.

from react-native-modal-dropdown.

ajonno avatar ajonno commented on July 29, 2024 3

my tests on device seem to indicate that animated={false} makes taps work on first try. there's a slight lag but certainly first tap works

from react-native-modal-dropdown.

 avatar commented on July 29, 2024 2

It is still happening to me with 0.5.0.

from react-native-modal-dropdown.

Werewolve avatar Werewolve commented on July 29, 2024 1

It is still happening to me!

from react-native-modal-dropdown.

Dror-Bar avatar Dror-Bar commented on July 29, 2024 1

@Werewolve
Could you possibly be trying to access the dropdown after clicking a textInput (or triggering the keyboard somehow)? this was the cause of the problem for me.

from react-native-modal-dropdown.

ravirupareliya avatar ravirupareliya commented on July 29, 2024 1

Passing keyboardShoudPersistTaps="always" in ModalDropdown component works for me

from react-native-modal-dropdown.

sohobloo avatar sohobloo commented on July 29, 2024

Do you render the option row yourself or use the default render.

from react-native-modal-dropdown.

ARMATAV avatar ARMATAV commented on July 29, 2024

+1 This is what I thought disabling the fade-in animation would fix

from react-native-modal-dropdown.

ajonno avatar ajonno commented on July 29, 2024

We really need this fixed as soon as possible. I'll give animated=false a try today in mean time

from react-native-modal-dropdown.

sohobloo avatar sohobloo commented on July 29, 2024

@ajonno
Still an issue when animation closed?

from react-native-modal-dropdown.

ajonno avatar ajonno commented on July 29, 2024

let me double check stay tuned..

from react-native-modal-dropdown.

ajonno avatar ajonno commented on July 29, 2024

unf. this is still a problem and we had to backlog it. picked it up again now and trying to resolve. setting animation=false isnt making any difference re our tests on device. we can confirm that it is specifically 2 taps.

(we are using a bound function on renderRow= .. )

1st tap does nothing, 2nd tap is recognised.

from react-native-modal-dropdown.

ajonno avatar ajonno commented on July 29, 2024

ok have figured it out. For our use case, we need to have keyboardShoudPersistTaps="always" . This ensures, that the first tap on a row in the (react-native-modal-dropdown) ListView is recognised and handled. We'll submit a change/pull request shortly, greatly appreciate if you can review asap and merge. Thanks!

from react-native-modal-dropdown.

sohobloo avatar sohobloo commented on July 29, 2024

@ajonno
Great. I'm ready and thank you.

from react-native-modal-dropdown.

ajonno avatar ajonno commented on July 29, 2024

my pleasure! i just tried a fresh install via yarn (yarn add react-native-modal-dropdown) but the change isn't there. do you need to bump the version number to 0.4.4 ?

from react-native-modal-dropdown.

DanAndreasson avatar DanAndreasson commented on July 29, 2024

Has this been fixed and released? https://www.npmjs.com/package/react-native-modal-dropdown lists 0.4.3 as latest

from react-native-modal-dropdown.

ajonno avatar ajonno commented on July 29, 2024

brilliant many thanks

from react-native-modal-dropdown.

LuckyStubs avatar LuckyStubs commented on July 29, 2024

Close the issue?

from react-native-modal-dropdown.

amirsc avatar amirsc commented on July 29, 2024

Hi, i'm not sure whether it's the same problem, but i have a page with multiple dropdowns, and if one of them is expanded i have to tap twice to open another one, first tap will close the current dropdown, second will expand the other one. I'm using the default renderRow, tried both
animated={false}
and
keyboardShouldPersistTaps="always"

from react-native-modal-dropdown.

Werewolve avatar Werewolve commented on July 29, 2024

@Dror-Bar there is no textInput on the screen. I have three dropdowns on the screen, maybe that cause the problem. After selecting the index that I store in the state is the old one, after selecting again the index ist correct.

from react-native-modal-dropdown.

jim-at-jibba avatar jim-at-jibba commented on July 29, 2024

@Dror-Bar

Hey, I am having the issue with having to double click and the dropdown is in a textInput, same as you. How did you fix it?

Thanks

from react-native-modal-dropdown.

Yaolegol avatar Yaolegol commented on July 29, 2024

Passing keyboardShoudPersistTaps="always" in ModalDropdown component works for me

(keyboardShou" l "dPersistTaps="always") - don't miss a letter "l"!!!

from react-native-modal-dropdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.