Comments (6)
joshmorel
commented on August 9, 2024
2
As a user I probably woudln't want my email exposed and I don't think the password hash should be exposed. There may be others as well... it probably would be worth explicitly setting things as private (email) vs public (username, profile image, bio).
Having users decide what is private/public (some may want email/full name as public, others not) increases complexity but may be worth considering in future.
from software-engineering-daily-api.
crablar
commented on August 9, 2024
Are there sensitive fields that need to be hidden?
from software-engineering-daily-api.
crablar
commented on August 9, 2024
Good point. Adding @jasonify for visibility.
from software-engineering-daily-api.
jasonify
commented on August 9, 2024
Ah yeah, we don't want to be exposing either of these. For now we can omit the password hash + emails by default as a quick solution.
Though if we add a note to the email being public (like on github for example), that might be okay too. Not sure how much of a problem email scrapers are these days.
from software-engineering-daily-api.
crablar
commented on August 9, 2024
The difference is that you can opt out of public email on Github.
from software-engineering-daily-api.
jasonify
commented on August 9, 2024
True, had that same thought after I commented. We should hide them for now until we add that functionality.
from software-engineering-daily-api.
Related Issues (20)
- Improve Onboarding Experience
- Add "upvoted" and "downvoted" to 'listened' api, for recent activity feed
- Ability to Save to Listen Later From Desktop To Phone HOT 2
- Add section to readme for env vars
- Automatically Scrape "Show Notes" and add them to "Related Links" HOT 1
- Create Wiki Feature Backend
- Create notifications backend
- Architect badge system
- Guest object system project
- Missing `AWS_PROFILE_PIC_BUCKET_NAME` in development image tag HOT 5
- As a listener, I would like to filter out episodes I have listened to HOT 2
- Prevent broken `author` ObjectId references in forumthreads collection HOT 1
- MP3 URL is not provided as https
- New route with less user info for comments
- [Help] How to populate Posts? I could not find any POST request to populate /api/posts HOT 6
- Bookmarks Question HOT 8
- Rename Backend Heroku API
- Migrate to Render
- Migrate api code to typescript
- Migrate api to graphql for easier cross-platform access and addressability on the frontend
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from software-engineering-daily-api.