Code Monkey home page Code Monkey logo

Comments (12)

ltratt avatar ltratt commented on June 12, 2024 1

I see the same. Lord alone knows what's caused that! I'll try causing a doc rebuild and see if it fixes it.

from grmtools.

ltratt avatar ltratt commented on June 12, 2024 1

"Latest release" is 0.13.1 (at the moment!); "master" is the tip of the github repo. In general, you probably want "latest release".

[I still think the "master" documentation shouldn't be broken, as people do read it. But I've not got any obvious ideas for fixing it right now!]

from grmtools.

ltratt avatar ltratt commented on June 12, 2024 1

And fixed -- thanks both for pointing this out and bearing with me while I wrapped my head around what the issue was!

from grmtools.

Benjscho avatar Benjscho commented on June 12, 2024

Looking a little further, this appears to only be affecting the lrpar crate for the master release, not latest.

from grmtools.

ltratt avatar ltratt commented on June 12, 2024

That didn't fix it. @ratmice I don't suppose you have any ideas? If not, I'll do an in-depth investigation tomorrow.

from grmtools.

Benjscho avatar Benjscho commented on June 12, 2024

Could it be an issue with rust doc nightly versions? Looking at the doc pages it looks like master is being built with rustdoc 1.69.0-nightly (4507fdaaa 2023-02-18) but latest is using rust doc 1.69.0-nightly (d7948c843 2023-01-26). The master docs are also missing the rust doc toolbar at the top. Maybe pinning rust doc would fix it

from grmtools.

Benjscho avatar Benjscho commented on June 12, 2024

Also sorry I'm a little unclear on how latest and master differ/what they both build from

from grmtools.

ratmice avatar ratmice commented on June 12, 2024

I can reproduce it locally using RUSTDOCFLAGS="-Dwarnings" cargo +nightly doc --no-deps which adds the +nightly flag to the command line used in .buildbot.sh. While everything works fine without the +nightly.

from grmtools.

ltratt avatar ltratt commented on June 12, 2024

@ratmice You're a genius -- I was looking in the wrong place until you pointed out this is "nightly" related. I'll do the fix now; it'll take someone until tomorrow to review it (we have a post-PR snare script that uploads the docs to github which, embarrassingly, I'd completely forgotten about). With luck this will be fixed in about 12 hours from now!

from grmtools.

Benjscho avatar Benjscho commented on June 12, 2024

Ace, thank you!

from grmtools.

ratmice avatar ratmice commented on June 12, 2024

Actually Ben was the first to point out nightly, credit where credit is due!

from grmtools.

ltratt avatar ltratt commented on June 12, 2024

Mea culpa! Let's say the one safe thing is that I made several mistakes :p

from grmtools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.