Capture self in acknowledgement callback about socket.io-client-swift HOT 12 CLOSED

Thanks for the good issue report.

I don't really know Objective-C well, but from your test code it looks like you're creating a local variable named socket and working with that. Once socket goes out of scope it should be released.

Does this happen if you make the socket a member of the viewcontroller?

I usually have the socket be a member of the viewcontroller, and then do things like this in the viewDidLoad https://github.com/nuclearace/socket.io-client-swift-example/blob/master/TicTacIOiOS/ViewController.swift#L28

from socket.io-client-swift.

Also, I should note I have no idea if Objective-C blocks are as powerful as Swift closures.

from socket.io-client-swift.

Thanks for a quick reply - I will look into it and report my findings. 😄

I know less swift than objective-c so I have my work cut out for me. 😄

from socket.io-client-swift.

Hm, actually I'm getting this too.

from socket.io-client-swift.

What's weird is this seems to work in Swift.

from socket.io-client-swift.

Also the code it's highlighting isn't the problem.

from socket.io-client-swift.

Swift 1.2 seems to get the line right, but I still can't figure out why it's happening

from socket.io-client-swift.

What's even weirder is that it doesn't seem to happen when I do something crazy like

SocketIOClient* gSocket;

void testSocketAck()
{
    gSocket = [[SocketIOClient alloc] initWithSocketURL:@"localhost:8080" options:nil];

    [gSocket on: @"connect" callback: ^(NSArray* data, void (^ack)(NSArray*)) {
        NSLog(@"connected");
        [gSocket emitWithAckObjc:@"ack" withItems:@[@1]](1, ^(NSArray* data) {
            NSLog(@"Got ack");
            NSLog(@"%@", data[0]);
            [gSocket emitObjc:@"test" withItems:@[]];
        });
    }];

    [gSocket connect];
}

from socket.io-client-swift.

Ugh, I found a really ugly workaround.

If you have a global variable that references your object, and then use that inside blocks it works.

from socket.io-client-swift.

@ahallora Actually I think I've found a solution

- (void) sendMessage {
    __block int i;

    [[self socket] emitWithAckObjc:@"ack" withItems:@[@1]](1, [^(NSArray* data) {
        NSLog(@"Got ack");

        [[self socket] emitObjc:@"test" withItems:@[]];
        i = 1 + 1;
    } copy]);
}

Can you confirm that sending the copy message to the block fixes it.

If that's the case, I'll update the readme

from socket.io-client-swift.

This is actually a problem with Swift-Objective-C compatibility. I worked out a small demo here

from socket.io-client-swift.

Awesome, it works! Thank you so much! 👍 😃

from socket.io-client-swift.