Code Monkey home page Code Monkey logo

Comments (1)

AmineDiro avatar AmineDiro commented on August 20, 2024

Hello,
I would love to contribute to this project and this issue. I have some experience working with Milvus in both Python and GO, I see that you support qdrant as a vector store for now. I have some questions regarding the implementation :

  • As I can see from the qdrant implementation, all the collection creation details are given to the user (embedding_dim size, distance, index type ... ) and the Qdrant struct only has the client instance. Should the Milvus offer the same flexibility or hide the collection creation details, the index type, etc... from the user?
  • Index creation is an additional step in Milvus, should we integrate this from the llm-milvus side: for example at query time check if an index on the collection exists and is loaded, if not create it.
  • The add_text and add_documents methods return Vec<String>, where string are UUIDs generated by the client in Qdrant. Milvus has an auto_id FieldSchema, we could parse the response or create an additional Id field with UUID to have the same interface ?

I really hope I could help on this issue. Thanks for your answers !

from llm-chain.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.