Code Monkey home page Code Monkey logo

Comments (7)

snuffyDev avatar snuffyDev commented on May 27, 2024

I've thought about that early on. Unfortunately, the only options for how it can be implemented are

Send a search to YTM, parse the data, find the album thumbnail, send it back

or

Send a HTTP request to a 3rd party API/DB and get the thumbnail that way.

Problem with the first option is how much processing would need to be done (which is a lot). The second one is a better option, but that would mean being dependent on the chosen 3rd party service - which wouldn't be optimal. Not to mention, either method would mean songs would load slower, since there'd be an added HTTP request for each song load.

If you have any suggestions or any better solutions let me know, I'll see what I can do

from beatbump.

davidcollini avatar davidcollini commented on May 27, 2024

Yeah that’s about what I expected, but it was worth a shot

from beatbump.

davidcollini avatar davidcollini commented on May 27, 2024

You can prolly close this issue, but it’s up to you

from beatbump.

davidcollini avatar davidcollini commented on May 27, 2024

https://user-images.githubusercontent.com/89056889/157370137-a5261f9c-d397-41fa-9958-bbc852856d8c.MOV This song has a music video, but when searching for it, the album art is shown, but when playing it in the album the music video thumbnail is shown, could the same source be parsed for each that would allow the song to always show the album art?

from beatbump.

davidcollini avatar davidcollini commented on May 27, 2024
Upload.from.GitHub.for.iOS.MOV

from beatbump.

snuffyDev avatar snuffyDev commented on May 27, 2024

user-images.githubusercontent.com/89056889/157370137-a5261f9c-d397-41fa-9958-bbc852856d8c.MOV This song has a music video, but when searching for it, the album art is shown, but when playing it in the album the music video thumbnail is shown, could the same source be parsed for each that would allow the song to always show the album art?

Unfortunately, I don't think I'll be able to do much about that. The reason the album art shows when you search it is because 'Songs' is the default search filter, which will only show audio-only official song releases (their thumbnails are the album art).
If a song has a music video, then they're two totally different uploads, which have different IDs so therefore the API returns different data for them.

Song ID is: 9BrQUWQV1XQ

Video ID is: aNYjOVo5IEw

YouTube Music also has this annoyingly, since when the album was uploaded to their site, for whatever reason the video was chosen to be in the album instead of the song (https://music.youtube.com/watch?v=9BrQUWQV1XQ)

from beatbump.

davidcollini avatar davidcollini commented on May 27, 2024

Dang, that sucks :/

from beatbump.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.