Comments (7)
I've thought about that early on. Unfortunately, the only options for how it can be implemented are
Send a search to YTM, parse the data, find the album thumbnail, send it back
or
Send a HTTP request to a 3rd party API/DB and get the thumbnail that way.
Problem with the first option is how much processing would need to be done (which is a lot). The second one is a better option, but that would mean being dependent on the chosen 3rd party service - which wouldn't be optimal. Not to mention, either method would mean songs would load slower, since there'd be an added HTTP request for each song load.
If you have any suggestions or any better solutions let me know, I'll see what I can do
from beatbump.
Yeah that’s about what I expected, but it was worth a shot
from beatbump.
You can prolly close this issue, but it’s up to you
from beatbump.
https://user-images.githubusercontent.com/89056889/157370137-a5261f9c-d397-41fa-9958-bbc852856d8c.MOV This song has a music video, but when searching for it, the album art is shown, but when playing it in the album the music video thumbnail is shown, could the same source be parsed for each that would allow the song to always show the album art?
from beatbump.
Upload.from.GitHub.for.iOS.MOV
from beatbump.
user-images.githubusercontent.com/89056889/157370137-a5261f9c-d397-41fa-9958-bbc852856d8c.MOV This song has a music video, but when searching for it, the album art is shown, but when playing it in the album the music video thumbnail is shown, could the same source be parsed for each that would allow the song to always show the album art?
Unfortunately, I don't think I'll be able to do much about that. The reason the album art shows when you search it is because 'Songs' is the default search filter, which will only show audio-only official song releases (their thumbnails are the album art).
If a song has a music video, then they're two totally different uploads, which have different IDs so therefore the API returns different data for them.
Song ID is: |
Video ID is: |
YouTube Music also has this annoyingly, since when the album was uploaded to their site, for whatever reason the video was chosen to be in the album instead of the song (https://music.youtube.com/watch?v=9BrQUWQV1XQ)
from beatbump.
Dang, that sucks :/
from beatbump.
Related Issues (20)
- [BUG] Default HLS proxy doesn't work on Firefox
- [BUG] Triple dots icon not working in search section "Videos"
- [BUG] Song's previous button doesn't start song from the beginning
- [FEAT] When clicked on a searched playlist or album, you get access to a list of songs to choose from HOT 1
- [BUG] Favorite songs don't sync while being searched
- [FEAT] Artists can be marked as favorites
- [BUG] (Not all) opened albums from Home or Trending pages don't load
- [BUG] "Looks like you hit a dead end" screen doesn't redirect
- [FEAT] Search song by YouTube's song ID HOT 1
- [BUG] Fail to build docker image (maybe add suport for arm64?) HOT 5
- [FEAT] Leave search string in search field HOT 2
- [FEAT] Delete song in a playlist
- Predirect extension for redirecting to alternative frontends HOT 5
- not able to change song
- [BUG] HOT 4
- [BUG] Recently, a lot of errors while playing HOT 1
- [BUG] Recently - TypeError: n.playabilityStatus is undefined
- [BUG] Music doesn’t play. HOT 2
- [FEAT] Multiple language support HOT 1
- [BUG] Error 500 from the API not letting to play any song
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beatbump.