snowplow / iglu-ruby-client Goto Github PK

View Code? Open in Web Editor NEW

3.0 18.0 3.0 49 KB

Ruby and JRuby client for Iglu

Ruby 95.21% Shell 4.79%

json-schema json iglu snowplow validation data

iglu-ruby-client's Introduction

Ruby client for Iglu

A Ruby client and resolver for Iglu schema repositories from the team at Snowplow Analytics.

Find out more

Technical Docs	Setup Guide	Roadmap	Contributing

Technical Docs	Setup Guide	Roadmap	Contributing

Copyright and License

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this software except in compliance with the License.

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

iglu-ruby-client's People

Contributors

Stargazers

Watchers

Forkers

sparrovv simplybusiness

iglu-ruby-client's Issues

Remove Ruby 2.0.0 support

We need to drop Ruby 2.0.0 support as of 0.2.0 release because public_suffix-3.0.0 requires ruby >= 2.1 .

Detailed information can be found here

Switch to rubygems provider

More info here: travis-ci/dpl#574

Until this bug is fixed we're using non-standrard script provider.

Fix SchemaVer.parse_schemaver parses invalid SchemaVer

[31] pry(main)> Iglu::SchemaVer.parse_schemaver("foo")
=> #<Iglu::SchemaVer:0x1fda2814 @addition=0, @model=0, @revision=0>

Remove unnecessary ResolverError check from cache

I have 2 naive questions regarding Registries::ResolverError.

Here cache result is checked if it is an instance of Registries::ResolverError.

If I don't miss something, registry failures are stored in failures array and aren't stored in cache, so I don't expect to see error in cache. Why is it checked for an error in cache result at all?
It is likely I missed something and in case registry failure might be stored in cache, my 2nd question comes up. Neither EmbeddedRegistryRef.lookup_schema() nor HttpRegistryRef.lookup_schema() raise Registries::ResolverError . Only place where this error is used is here to raise it, not to push it to cache. Why is this specific error checked for a cache result?

Solving these questions would help me understand codebase and client behavior better.

Appreciate any help. @chuwy

RUBYGEMS_SNOWPLOW_API_KEY