Code Monkey home page Code Monkey logo

Comments (14)

kingo55 avatar kingo55 commented on August 15, 2024

Perhaps these two images explain it best:

Normal search terms:
sp-refr_urlhost2

Not provided / advertising?:
sp-refr_urlhost1

Here's the query:

SELECT
  Distinct refr_term,
  "count"(*)
FROM
  "atomic".events
WHERE
  refr_urlhost = 'au.search.yahoo.com'
GROUP BY
  1
ORDER BY
  2 DESC

from referer-parser.

alexanderdean avatar alexanderdean commented on August 15, 2024

Right - sounds like we should add 'au.yahoo.com' to the unknown section at the top of the referers.yml, to reduce these search false positives (i.e. au.yahoo.com will be identified as unknown rather than search). Makes sense?

from referer-parser.

kingo55 avatar kingo55 commented on August 15, 2024

Sure. I am just a little hesitant because it looks like a pattern among many of the Yahoo domains in the yaml. Plus I don't have a huge amount of data to confirm this against what I'm seeing in my Snowplow install.

To name a few which also may be generating false positives:

  - yahoo.com
  - ar.yahoo.com
  - au.yahoo.com
  - br.yahoo.com
  - chinese.yahoo.com
  - de.yahoo.com
  - dk.yahoo.com
  - es.yahoo.com

from referer-parser.

alexanderdean avatar alexanderdean commented on August 15, 2024

Hey @kingo55 - @fblundun is back working on this library at the moment. Shall we add those 8 domains you list into our unknown section at the top to prevent false positives?

from referer-parser.

kingo55 avatar kingo55 commented on August 15, 2024

Ah awesome. Mind if I run a quick test first?

I want to make sure we're not going to mislabel genuine search traffic.
E.g. Secure searches where the keyword isn't provided.

PS. Massively excited to see all the other improvements coming!
On 26 Jun 2014 22:42, "Alexander Dean" [email protected] wrote:

Hey @kingo55 https://github.com/kingo55 - @fblundun
https://github.com/fblundun is back working on this library at the
moment. Shall we add those 8 domains you list into our unknown section at
the top to prevent false positives?


Reply to this email directly or view it on GitHub
#57 (comment)
.

from referer-parser.

alexanderdean avatar alexanderdean commented on August 15, 2024

No probs - go ahead Rob!

from referer-parser.

kingo55 avatar kingo55 commented on August 15, 2024

Ok, I can't find a way to produce referrers with au.yahoo.com, but Yahoo's
secure search appears to pass a referrer on with the visitor. You may want
to decide if you want to keep that particular referrer in.

Just second guessing since I notice Google Analytics includes that traffic
under search traffic, too.

On 26 Jun 2014 23:28, "Alexander Dean" [email protected] wrote:

No probs - go ahead Rob!


Reply to this email directly or view it on GitHub.

from referer-parser.

kingo55 avatar kingo55 commented on August 15, 2024

Yahoo search referrals always seem to come under r.search.yahoo.com/__ylt=...

On 27 Jun 2014 00:02, "Rob Kingston" [email protected] wrote:

Ok, I can't find a way to produce referrers with au.yahoo.com, but
Yahoo's secure search appears to pass a referrer on with the visitor. You
may want to decide if you want to keep that particular referrer in.

Just second guessing since I notice Google Analytics includes that traffic
under search traffic, too.

On 26 Jun 2014 23:28, "Alexander Dean" [email protected] wrote:

No probs - go ahead Rob!


Reply to this email directly or view it on GitHub.

from referer-parser.

fblundun avatar fblundun commented on August 15, 2024

Hi @kingo55 ,
Just asking to clarify: Do you think that those eight domains should all go into the unknown section? Or do you think that some of them might be genuine "search" referers?

from referer-parser.

kingo55 avatar kingo55 commented on August 15, 2024

Hi @fblunden

Which domains are you referring to?
On 28 Jun 2014 00:14, "Fred Blundun" [email protected] wrote:

Reopened #57 #57.


Reply to this email directly or view it on GitHub
#57 (comment).

from referer-parser.

fblundun avatar fblundun commented on August 15, 2024

Your list from April:

  - yahoo.com
  - ar.yahoo.com
  - au.yahoo.com
  - br.yahoo.com
  - chinese.yahoo.com
  - de.yahoo.com
  - dk.yahoo.com
  - es.yahoo.com

from referer-parser.

kingo55 avatar kingo55 commented on August 15, 2024

Ah yes I was looking at the wrong PR.

Up to you guys how you want to treat those referrers. My findings indicated
they should be OK to add as unknown. I was skeptical that they might mask
Yahoo secure searches, but I don't think so anymore.
On 28 Jun 2014 00:23, "Fred Blundun" [email protected] wrote:

Your list from April:

  • yahoo.com
  • ar.yahoo.com
  • au.yahoo.com
  • br.yahoo.com
  • chinese.yahoo.com
  • de.yahoo.com
  • dk.yahoo.com
  • es.yahoo.com


Reply to this email directly or view it on GitHub
#57 (comment)
.

from referer-parser.

alexanderdean avatar alexanderdean commented on August 15, 2024

Okay great - let's add them to the list of unknowns then Fred! Thanks Rob...

from referer-parser.

alexanderdean avatar alexanderdean commented on August 15, 2024

Hmm - there's a lot of other country domains in there. I'm nervous someone is going to not like us changing this. Suggest we pause and think about #19 instead

from referer-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.