Create a snowdrop-spring-boot-dependencies bom about spring-boot-bom HOT 10 CLOSED

Many thanks @gytis. Great job :-)
If the result of the comparison are cosmetics (see previous comment), then I propose that we adopt it. Do you agree @metacosm @ebullient @geoand ?

from spring-boot-bom.

Just wanted to post an update here since it has been a while since the last communication. The latest proposed version on the BOM change is available here #70.

The main argument agains it was the lack of comments in the generated BOM. I would like to reiterate that the comments would still be available in GitHub and would only be removed from a file that is pushed to Maven Central.

Does anybody have any other arguments agains the use of flattening plugin or any other proposed changes other than the lack of comments? @cmoulliard @geoand @metacosm @aureamunoz @iocanel

from spring-boot-bom.

@cmoulliard reply to what? I'm the one who proposed the changes, so of course I agree with them :)

from spring-boot-bom.

I've pushed the new BOM format to sb-2.2.x branch (6e3f6b9). I'll create the followup tasks shortly.

from spring-boot-bom.

Thanks for the request, Erin. You're correct, so far this is a way to use our spring-boot-bom. The main reason being that we only support a subset of the dependencies and no plugins.

I cannot promise you anything at the moment, because such a parent would require an extra maintenance effort from the whole team. But we have a team meeting scheduled on Monday, so I'll make sure to raise the issue there and will get back to you ASAP.

from spring-boot-bom.

I don't and honestly for me the lack of comments is not a problem.

from spring-boot-bom.

I can try it. I just needed a poke to do so. =)

from spring-boot-bom.

Before to take a decision, we need at least to have some tests results to compare if the dependency:tree using it will be different vs not using it. Can you make such a comparison @gytis @ebullient ?

from spring-boot-bom.

@cmoulliard as asked I did some comparisons with the current and proposed bom/parent. The latest version is here https://github.com/snowdrop/spring-boot-bom/blob/spring-boot-parent-poc-v2/pom.xml. And in this gist you can see how it would look once pushed to a maven repository: https://gist.github.com/gytis/3757b5299e1ee23bb817a09d5a043d2a.

First of all, I've rebased POC branch to have the latest BOM commits. And then I tried HTTP REST example and generated dependency trees with different boms.

Here you can see pom.xml comparison between two approaches in the example application: gytis/rest-http-example@sb-2.1.x...gytis:sb-2.1.x-snowdrop-dependencies#diff-600376dffeb79835ede4a0b285078036.

Dependency trees are available here: https://github.com/gytis/rest-http-example/tree/sb-2.1.x-snowdrop-dependencies. As you can see they are virtually the same. The only differences are:

1. More recent maven-dependency-plugin version
2. spring-boot-devtools becomes optional
3. More recent rest-assured version

from spring-boot-bom.

Do you agree

@gytis Can you also reply ?

from spring-boot-bom.