Code Monkey home page Code Monkey logo

Comments (3)

leoisl avatar leoisl commented on August 26, 2024

I totally agree with this idea, it is indeed a very nice improvement!

I am not sure if we should worry about this (from https://unix.stackexchange.com/questions/32795/what-is-the-maximum-allowed-filename-and-folder-size-with-ecryptfs):
.

Linux has a maximum filename length of 255 characters for most filesystems (including EXT4), and a maximum path of 4096 characters.

filename length is not an issue, but when we add all wildcards of a rule to the log filepath, its length increases a lot. Sometimes I have rules where the wildcards are full paths to other files, but I don't think I ever hit the limit. Anyway, we can ensure the path has at most 4096 character, and cut some of the wildcards in case it exceeds, but I am just wondering if we should address this or not (seems like a rare corner case)?

That is the only possible issue I see we need to tackle, the rest is all fine. I really like this proposal

from lsf.

mbhall88 avatar mbhall88 commented on August 26, 2024

I think 4096 characters is more than sufficient. If someone hit that due to wildcards I would suggest there might be some changes they could make to their pipeline.

I think enforcing it is hard as I guess it could vary from file system to file system?

from lsf.

leoisl avatar leoisl commented on August 26, 2024

Yeah, I would just consider common linux filesystem, probably just EXT4. I think we should drop this. Hard to do it properly (work on any filesystem), and will tackle an extremely rare corner case.

from lsf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.