Example for 1inchV4 router swap about 1inch-swap HOT 5 CLOSED

Never mind, I messed up some things myself. This example also works for v4!

Hey!

Glad you got it working 🙂

Will just leave what I think are the answers to your question below just in case anyone else finds them in the same situation:

1. _data[4:] is for removing the function selector from the calldata returned by the 1inch API. The function selector determines what function is called

2. V4 adds an extra return value spentAmount on the swap function:

   function swap(
           IAggregationExecutor caller,
           SwapDescription calldata desc,
           bytes calldata data
       )
           external
           payable
           returns (
               uint256 returnAmount,
               uint256 spentAmount,
               uint256 gasLeft
           )
       {

   So replace

    (uint returnAmount, uint gasLeft) = abi.decode(_data, (uint, uint));

   with

   (uint returnAmount, uint spentAmount, uint gasLeft) = abi.decode(_data, (uint, uint, uint));

from 1inch-swap.

Never mind, I messed up some things myself. This example also works for v4!

from 1inch-swap.

2. V4 adds an extra return value spentAmount on the swap function:

   function swap(
           IAggregationExecutor caller,
           SwapDescription calldata desc,
           bytes calldata data
       )
           external
           payable
           returns (
               uint256 returnAmount,
               uint256 spentAmount,
               uint256 gasLeft
           )
       {

This is true for Ethereum but it seems 1inch has not updated this on Polygon and binance smart chain.
There, the old return parameters are still used

from 1inch-swap.

Never mind, I messed up some things myself. This example also works for v4!

Hey!

Glad you got it working 🙂

Will just leave what I think are the answers to your question below just in case anyone else finds them in the same situation:

1. _data[4:] is for removing the function selector from the calldata returned by the 1inch API. The function selector determines what function is called

2. V4 adds an extra return value spentAmount on the swap function:

   function swap(
           IAggregationExecutor caller,
           SwapDescription calldata desc,
           bytes calldata data
       )
           external
           payable
           returns (
               uint256 returnAmount,
               uint256 spentAmount,
               uint256 gasLeft
           )
       {

   So replace

    (uint returnAmount, uint gasLeft) = abi.decode(_data, (uint, uint));

   with

   (uint returnAmount, uint spentAmount, uint gasLeft) = abi.decode(_data, (uint, uint, uint));

Hey @smye, you assume the return type for swap() on V4 with extra spentAmount at positional arg. number 2. But 1inch docs for V4 says prototype is still the old V3 prototype. Can you confirm which is correct?

from 1inch-swap.

Never mind, I messed up some things myself. This example also works for v4!

Hey!
Glad you got it working 🙂
Will just leave what I think are the answers to your question below just in case anyone else finds them in the same situation:

1. _data[4:] is for removing the function selector from the calldata returned by the 1inch API. The function selector determines what function is called

2. V4 adds an extra return value spentAmount on the swap function:

   function swap(
           IAggregationExecutor caller,
           SwapDescription calldata desc,
           bytes calldata data
       )
           external
           payable
           returns (
               uint256 returnAmount,
               uint256 spentAmount,
               uint256 gasLeft
           )
       {

   So replace

    (uint returnAmount, uint gasLeft) = abi.decode(_data, (uint, uint));

   with

   (uint returnAmount, uint spentAmount, uint gasLeft) = abi.decode(_data, (uint, uint, uint));

Hey @smye, you assume the return type for swap() on V4 with extra spentAmount at positional arg. number 2. But 1inch docs for V4 says prototype is still the old V3 prototype. Can you confirm which is correct?

Nevermind, found it -- https://etherscan.io/address/0x1111111254fb6c44bac0bed2854e76f90643097d#code#L2319
Doc hasn't been updated.

from 1inch-swap.