TCP hangs when sending about smoltcp HOT 7 CLOSED

Oh yeah you hit a bug; retransmit timer gets reset by ACKs whereas it should not.

Specifically, by duplicate ACKs that arrive when the window is zero length, and pass through the duplicate ACK checks because they count as keepalives.

from smoltcp.

Thanks for looking at it, now I have to read the RFCs along with the code and find out how the timer is supposed to be set and kept.

from smoltcp.

Ok, finally got it working. Besides keeping the retransmission timer there was an overflow that needed to be fixed. Preparing a PR now.

from smoltcp.

@pothos I'm finally making progress on this—see d1e2292 for one method I'm using to expose underlying bugs. I am afraid that your fix is hiding one of them.

from smoltcp.

@pothos I've integrated a test quite like your taptest in the commit 44db954. I've managed to expose one other bug as well.

from smoltcp.

Fixed in b247f64.

from smoltcp.

Thanks for including the fix - I am happy that the wrapping can be covered without distinction of cases ;)

from smoltcp.