Code Monkey home page Code Monkey logo

Comments (1)

smnorris avatar smnorris commented on June 11, 2024

In bcfishpass.modelled_stream_crossings see column modelled_crossing_type_source.
For 4606812 (about 7km south of Fernie on the CP line) it is GBA_RAILWAY_STRUCTURE_LINES_SP, GBA_RAILWAY_STRUCTURE_LINES_SP, GBA_RAILWAY_STRUCTURE_LINES_SP.

This is the data source for that crossing: https://catalogue.data.gov.bc.ca/dataset/railway-structure-line

This is where it gets applied, bridges are taken from that layer:

Manually reviewed modelled crossings status changes are all here: https://github.com/smnorris/bcfishpass/blob/main/01_prep/01_modelled_stream_crossings/data/modelled_stream_crossings_fixes.csv

Based on this review I think a few things could be improved:

  • modelled_crossing_type_source could be updated when applying the fixes from manual review - add a code something like MANUAL REVIEW
  • I'm not sure why the value GBA_RAILWAY_STRUCTURE_LINES_SP is repeated 3x in the current data. Probably because the script got run three times but that should be checked
  • more info from modelled_stream_crossings table could be pulled through into the unified crossings table so it is easier to work with

from bcfishpass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.