pscis_modelledcrossings_streams_xref QA about bcfishpass HOT 12 CLOSED

never mind. i see it now. incoming pr

from bcfishpass.

Note that there are currently 1844 records without a modelled_crossing_id, 1650 with - hopefully most of these 1850 are very close to a modelled crossing.

from bcfishpass.

Not really a bug but this is an important data fix

from bcfishpass.

Definitely an important data fix. FYI, when I am reviewing pscis crossings to scope for which crossings are good candidates for phase 2 I am populating a modelled_crossing_id_corr column with the associated modelled_crossing_id when it appears obvious that they are a match. I will submit match correction table as a pull request eventually.

from bcfishpass.

Please do.
I've made an automated fix based on distance for many of them. And CWF has reviewed a bunch more that weren't as close.. I haven't applied all of that fix yet, and there is also the handful of crossings that will take the most time where it really isn't clear what is going on.

from bcfishpass.

This should be fixed now

from bcfishpass.

I ahve a csv with a few crossings that I matched. Apparently, I can't attach a csv here. This is what it looks like. Let me know the best way to do this. There should maybe be a bunch more for the Bulkley unless they are already dealt with. I'm about to have a look now as it makes the reporting easier when I can match the hab con sites to bcfishpass outputs. Do you know if anyone else is already working on that?

stream_crossing_id modelled_crossing_id linear_feature_id reviewer notes
50095 4605747 706880116 AI Very little potential habitat upstream for cutthrout (>25% in 25m).
50090 4602849 706879645 AI If this is the mainstem, habitat upstream at bridge appears mod to high value.
50110 4605506 706872809 AI No habitat modelled upstream

from bcfishpass.

Some of them should be dealt with by #60 - I haven't pushed the result of that to the CWF db yet though, I'll do that now. It looks like those three are missed though, add them to pscis_modelledcrossings_streams_xref.csv to force the match, but leave out linear_feature_id if you are matching to a modelled crossing, it isn't needed. I added some bare bones doc here on how the lookup works https://github.com/smnorris/bcfishpass/tree/main/01_prep/02_pscis

from bcfishpass.

hmm. should I append to pscis_modelledcrossings_streams_xref.csv and burn a copy to the ali schema?

from bcfishpass.

Very open to different workflow suggestions but I am liking this for tracking changes to the lookup.

from bcfishpass.

Presuming we stick with this I'm already thinking I'll move all the data into one spot so it is front and centre in the repo and more obvious where edits should be made. #48

from bcfishpass.

seems like a great workflow to me. I can see why you put those files there in the first place but everything in one pile might be nice too

from bcfishpass.