Code Monkey home page Code Monkey logo

Comments (4)

MarijnS95 avatar MarijnS95 commented on July 17, 2024 1

@Drakulix Noticed the same while updating my toy project to develop and trying to understand why the previous implementation passed 32 for both fields (through fn bpp() and fn depth()), passing 32 indeed fixes the error (here and in legacy_modeset, atomic_modeset).

from drm-rs.

Drakulix avatar Drakulix commented on July 17, 2024

Well, I am not sure if depth or bpp values of "1" are actually valid.

Can you try chaging the arguments of add_framebuffer in kms-interactive to something more reasonable like &db, 32, 32? That might fix it.

from drm-rs.

Drakulix avatar Drakulix commented on July 17, 2024

Then please someone make a PR and fix the examples 😅 .
For a correct mapping between color-formats and bpp/depth, we would need to maintain a table ourselves, which I would rather not do (drm-fourcc has a lot of formats). (Which is why depth() and bpp() were dropped.)

But that should not be an issue of the examples, as they always use a hard-coded format. So we should just set the example to correct values for the given color format.

from drm-rs.

Drakulix avatar Drakulix commented on July 17, 2024

Closed via #85

from drm-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.