Comments (5)
Hm, looks like a bug. Good catch! Do you have a fix in mind?
from mzlib.
I'm a little uncertain about the history here. If I remember correctly, we decided not to hash on the ID for some reason, maybe basing the uniqueness on other properties. As for the monoisotopic mass, it seems like you want a little tolerance (1e-9), so I'm not sure how to handle that in a hash code. Rounding seems like an option, but that's not the same as a tolerance.
from mzlib.
I looked into this, and now I'm not sure this is a concern, since hash codes do not need to be unique. Unless this poses an actual problem, I vote to close this issue.
from mzlib.
The problem I'm encountering is in merging databases. Consider 2 databases both derived from the UniProt database but with additional sets of PTMs. They will have many of the same mods at positions along proteins in the databases. In merging, it would be nice to make a hash set of modifications at each position and call it a day. Instead, the hash set behaves weirdly, getting rid of ModificationWithMass
objects that have very different masses and different IDs.
We already use HashSets of Modification objects (here and here), so we should be careful here.
from mzlib.
The test I wrote yesterday works now... I think the tests weren't building properly at the end of the day yesterday. Thanks!
from mzlib.
Related Issues (20)
- Depracated PSI-MOD.obo.xml HOT 2
- extra line breaks in mgf cause crash in LoadAllStaticData HOT 1
- Create icon for mzLib HOT 7
- Improve clarity of lack of ThermoRawFileReader support for macOS
- MGF peak list parser expects field separator to be SPACE HOT 4
- Updating to use .NET 6; end of support for .NET 5 is May 8, 2022
- Can't build on mac HOT 11
- Kullback-Leibler Divergence is 0 if no peaks match HOT 2
- extra trailing tab in output HOT 2
- IsotopicDistribution returns masses and intensities as separate IEnumerables
- Normalization methods in SpectralSimilarity have side effects
- mzML reader enforces order of MS1 and MS/MS spectra in the file
- Calculated number of averagines is only 1500
- Zero-equivalent intensities in MzML.GetOneBasedScanFromDynamicConnection
- Null ChemicalFormula throws NullReferenceException
- Binary search related bug in MzSpectrum.Extract HOT 2
- UnimodLoader throws KeyNotFoundException HOT 1
- Legacy comment update HOT 1
- PSI-MOD download certificate error
- .NET 8 transition? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mzlib.