Generated thumbnail paths on Windows have backslashes in the url about easy-thumbnails HOT 7 CLOSED

Definitely sounds wrong... would like some more detail so I can figure out exactly where the problem lies.

Could you please provide the following info:

• the exact output you are getting for one incorrect thumbnail
• the raw value of the stored field

from easy-thumbnails.

in files.py Thumbnailer::get_thumbnail_name ends with the line:
return os.path.join(basedir, path, subdir, filename)
On windows this will join with the '' character. I think it should be:
return os.path.join(basedir, path, subdir, filename).replace('', '/')

The raw values are all stored with the correct forward slash (/).

from easy-thumbnails.

yep, seems right. Simpler version would just be '/'.join(bits) :)

from easy-thumbnails.

os.path.join is smart enough to know what to do with empty directories though. '/'.join is too naive and you can get things like basedir//subdir/filename instead of basedir/subdir/filename.

from easy-thumbnails.

Right, in fact looking closer, I'm not actually convinced that we need to do this.

ThumbnailFile uses the same logic as a FieldFile for url generation, which involves using the storage's url method. This method does the replacement.

How are you generating the url?

from easy-thumbnails.

You are correct I was doing it the sorl-thumbnail way, which was wrong.

{% thumbnail model.image 50x50 as image %}

Then I was using {{image}} instead of {{image.url}}

from easy-thumbnails.

Yeah, I upgraded a site recently and was bit with that. Glad we got to the bottom of it!

If you want to write some sorl-thumbnail upgrade docs, that'd be cool ;)

from easy-thumbnails.