Unit Testing in VS2010 Fails about s22.imap HOT 5 CLOSED

Thanks!

There is indeed a problem with a recent bugfix to the CreateAttachment method which causes the MessageWithAttachmentToMIME822 test to fail.

The MessageWithQuotedPrintables test on the other hand runs fine on my end. I'm on Visual Studio 2012, but the VS version really shouldn't have any impact on the test results...please let me know if you figure out what's going on.

cheers,
smiley22

from s22.imap.

Created Pull Request #38.
This solves the first issue, as well as changing the target version.
Could the change of TargetFrameworkVersion be tested on VS2012 to see if it is the cause of the MessageWithQuotedPrintables problem before I dig further?

Also is there any other preferred way to discuss development?

from s22.imap.

Okay it seems git (or Github) messed up the line breaks. The carriage returns have disappeared from the MailWithQuotedPrintables.txt file causing the test to fail. There's probably some auto CRLF conversion going on in git/github that I wasn't aware of. Will submit a fix tonight to resolve this.

from s22.imap.

I see, git defaults to normalizing all textfiles to LF line ending.
maybe .gitattributes can be used to handle this.
(github only have identical data as stored in your local git repo)

Maybe you can make more sense out of http://timclem.wordpress.com/2012/03/01/mind-the-end-of-your-line/

MessageWithQuotedPrintables works for me, guess some kind of change of settings during checkout solved this.
As such this is solved for now.

from s22.imap.

Just to clarify the MessageWithQuotedPrintables test, there is an issue with the lineending when it is checked out/in.
On the first checkout the .gitignore do not exist and the files are not "fixed" to the local format.

As such this issue with the testcase only appears on first clean checkout.
Mentioning this now since I will not take part of the fix from #42

from s22.imap.