OutOfMemory Exception about s22.imap HOT 10 CLOSED

Thanks,

I will look into it and see if I can find out what's going on.

from s22.imap.

Thank you!

OOM could be thrown by another reason for sure, but it was thrown on
GetResponse method of ImapClient
on the following line:

mem.WriteByte(b);
Thanks,
Victor

On Wed, Nov 28, 2012 at 5:30 PM, smiley22 [email protected] wrote:

Thanks,

I will look into it and see if I can find out what's going on.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-10797645.

from s22.imap.

I've found it. At some point server closes connection and an exception is thrown from GetResponse.
It starts cycling infinitely (hitting GetResponse method upto 6K times per second).

while (true) {
                try {
                    string response = GetResponse();
                    /* A request was made to stop idling so quit the thread */
                    if (response.Contains("OK IDLE"))
                        return;
                    /* Let the dispatcher thread take care of the IDLE notification so we
                     * can go back to receiving responses */
                    idleEvents.Enqueue(response);
                } catch (IOException) {
                    /* Closing _Stream or the underlying _Connection instance will
                     * cause a WSACancelBlockingCall exception on a blocking socket.
                     * This is not an error so just let it pass.
                     */
                }
            }

from s22.imap.

Ah okay so that's what it is, good job! I'll try to come up with a fix asap.

cheers,
smiley22

On Thu, Nov 29, 2012 at 5:15 AM, vchernyshev [email protected]:

I've found it. At some point server closes connection and an exception is
thrown from GetResponse.
It starts cycling infinitely (hitting GetResponse method upto 6K times per
second).

while (true) {
try {
string response = GetResponse();
/* A request was made to stop idling so quit the thread /
if (response.Contains("OK IDLE"))
return;
/ Let the dispatcher thread take care of the IDLE notification so we
* can go back to receiving responses /
idleEvents.Enqueue(response);
} catch (IOException) {
/ Closing _Stream or the underlying _Connection instance will
* cause a WSACancelBlockingCall exception on a blocking socket.
* This is not an error so just let it pass.
*/
}
}

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-10834503.

from s22.imap.

There's not much you can do when the server closes the connection, I guess it's best to just let the exception bubble up in this case. This is a pretty delicate part of the library and I want to make sure the changes are really bullet-proof, so feel free to give some feedback.

        while (true) {
            try {
                string response = GetResponse();
                /* A request was made to stop idling so quit the thread */
                if (response.Contains("OK IDLE"))
                    return;
                /* Let the dispatcher thread take care of the IDLE notification so we
                 * can go back to receiving responses */
                idleEvents.Enqueue(response);
            } catch (IOException e) {
                /* Closing _Stream or the underlying _Connection instance will
                 * cause a WSACancelBlockingCall exception on a blocking socket.
                 * This is not an error so just let it pass.
                 */
                if (e.InnerException is SocketException) {
                    /* WSAEINTR = 10004 */
                    if (((SocketException)e.InnerException).ErrorCode == 10004)
                        return;
                }
                /* If the IO exception was raised because of an underlying
                 * ThreadAbortException, we can ignore it. */
                if (e.InnerException is ThreadAbortException)
                    return;
                /* Otherwise let it bubble up */
                throw;
            }
        }

from s22.imap.

Thank you for the fix. One question though. What is best place to catch this bubbled exception?

from s22.imap.

Hello! I'm still getting OutOfMemory Exception on
private string GetResponse(bool resolveLiterals = true)
...
in mem.WriteByte(b);

from s22.imap.

okay thanks, will take another look at it

from s22.imap.

I have also seen an out of memory error in the GetResponse method.

The set-up when the error happens is that the call to the ImapClient constructor passed in useSSL = false and a port number of 993. The hostname was set to "outlook.office365.com". Fixing the useSSL to be true stopped the error.

Hope this helps.

from s22.imap.

I guess it'd be better to catch the exception in IdleLoop and raise some sort of error event..

from s22.imap.