Comments (6)
Could you clarify does existing behavior (card change) replace going back or card changes AND browser goes back?
In 2b8ea40 I already add visual indication (change is not visible in vdb.im yet, will be inluded in the next update) but I need to know do still need to make something with browsers defaults (disable going back by swipe there) or just visual indication will be sufficient?
from vdb.
The behaviour I am experiencing is the following: when I wish to just go back with the browser (and swipe to left or right is the default action to do so) if I do so by swiping over a card line in VDB (and not in a "safe" place on the web page) I also get as a result a change in the card number.
Not sure which is the best solution here, as swipe to left/right is the default/expected action to go back on Chrome mobile.
Visual indication would be awesome, but there still a collision of behaviour/actions, at least with Chrome mobile, the default browser on many Android phones. Maybe I should just lock the deck before changing page (with the fix from dab3abc )
from vdb.
I tested it on few devices around me and non of them had swipe-for-back behaviour on the default settings in Chrome from Store, so I don't have (at the moment) possibility to test how to disable it as it is something I cannot reproduce.
Would be great if anybody can provide their setup with the collision (phone model + android version + chrome version).
P.S. Anyway I dont want swipe-for-back behavior to overwrite existing change-card behavior (at least not until it become gold standard for major browsers on default settings OR there will be no ways of disabling it on my side OR there will be a lot of user requests to keep it), as I see it much less useful than changing card q-ty in case of VDB. It means once I get access to environment where it's possible to reproduce this swipe-as-back, next step is to disable swipe-as-back and only keep change-card.
from vdb.
All fair, I do completely understand. One final note on the swiping for back I mistakenly omitted: you actually have to start swiping from out of the screen border for it so maybe they do not completely overlap.
I assure you this the last comment and comes again with a big thank for your work: you can also accidentally change card number in case where you are not very precise in pinch-zooming or scrolling horizontally. For example when you have a deck with vampire with a lot of disciplines, the crypt section expands more than the Library section and you have to scroll to the side to see Clan/group on the right side.
Cheers!
from vdb.
Thanks a lot!
I'll investigate swiping from the border and maybe it will be possible to find proper solution (i.e. make swiping area for card-change to have some padding which is used for back-forward navigation).
As for scrolling, I'm already exploring option how to solve this proper way: to keep everything on the screen is important, as well as have other option to change card q-ty (clicks on tiny buttons as the only option looks poor, especially for guys with big thumbs).
from vdb.
Looks like fixed in bf57c22.
from vdb.
Related Issues (20)
- Absent from TWDA filter HOT 2
- Can't export deck HOT 2
- Searching for ADV does not result in a list with all ADV vampires HOT 2
- Overlay issue HOT 2
- [Feature Request] Deck compare feature HOT 1
- [Feature Request] Use the same sort menu for the deck/crypt than for the general crypt HOT 1
- Error when filtering crypt card HOT 1
- Add Set to Cards in Inventory HOT 10
- Problem in filtering library by discipline HOT 2
- 3rd edition players kit HOT 1
- Swipes to change Deck card does not respect locked decks HOT 1
- Card listing broken in Firefox HOT 5
- Add Missing in Inventory and generating proxy fails in PDF Proxy HOT 1
- trying to install development for local use HOT 2
- Missing Cards prints out only library cards and not crypt HOT 1
- TWDa filtering when `Crocodile's Tongue` is chosen library card fails HOT 1
- copying decklists from JOL requires manual intervention to parse the cards HOT 3
- Unexpected Application Error when searching PDA for Cryptic Rider HOT 1
- Request: Remove deck from inventory HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vdb.