Unnecessary mutex in awsauth.go? about go-aws-auth HOT 5 CLOSED

Which global map are you talking about, exactly?

from go-aws-auth.

awsauth.go: awsSignVersion has a mutex that protects it in the sign v3/v4 functions.

from go-aws-auth.

Ah, I see what you're talking about. The mutex doesn't protect that map, it protects the Keys variable. The Keys variable may be mutated on any call to any of the Sign functions. If your program has concurrent calls to Sign, there could be trouble.

Before locking this library into 1.0, I think we'll look for a better way to manage credentials.

from go-aws-auth.

Then I'm not sure that mutex is doing what you think. If I provide credentials that the chooseKeys function picks, holding that mutex does nothing to protect against the credentials being changed in some goroutine outside the context of your signing functions. If you are trying to protect against that specific case, you would need to stick a mutex on each credentials object and lock access there.

That said, as a user of the library I would be fine if the credentials struct was readonly once created and if I wanted new credentials (from say, an IAM or config file change) then it would be my responsibility to provide a new credentials struct instance and not modify an existing one that could be in-use -- or it would be my responsibility to mutex protect calls to any functions using them.

from go-aws-auth.

According to my reading of the code, the mutex was protecting a package-level (exported) Keys variable, which has since been removed. Let me know if I've unknowingly done something rash...

from go-aws-auth.