Log adapter errors about external-adapters-js HOT 4 CLOSED

I took a glance at this while working on the log size, do you have some steps to reproduce?

For example when I run amberdata without an API key the client gets:

{"jobRunID":"1","status":"errored","statusCode":500,"error":{"name":"AdapterError","message":"Invalid value \"undefined\" for header \"x-api-key\""}}

and the node operator sees:

{"message":"Could not reach endpoint: \"Invalid value \\\"undefined\\\" for header \\\"x-api-key\\\"\"","level":"error","instanceId":"68b86ad1-c120-47f2-a004-5245a3dff690","timestamp":"2021-01-07T18:15:26.890Z"}

Giving an invalid Requester.validateResultNumber path gives the following to the client:

{"jobRunID":"1","status":"errored","statusCode":500,"error":{"name":"AdapterError","message":"Result could not be found in path"}}

and to the node operator:

{"message":"Result could not be found in path","level":"error","instanceId":"bad3f72e-ff7b-4853-896f-354e4bd03e2d","timestamp":"2021-01-07T18:26:39.447Z"}

which also seem fine to me.

from external-adapters-js.

Following up - reproduced this while acceptance testing the Proof of Reserves composite adapter.

from external-adapters-js.

Those errors seem that are caught by the Requester. If you introduce any error, ie a throw inside the adapter execute function, the adapter will fail without notifying anything.

from external-adapters-js.

This should be covered by separate stories in Shortcut now

from external-adapters-js.