Need LSP workspace folders and events about refact-sublime HOT 13 CLOSED

I added refact/acceptCompletion method. Params: {snippet_telemetry_id: int}. snippet_telemetry_id came from refact/getCompletions

from refact-sublime.

The code already sends didopen and didchange events with the corresponding file name.

from refact-sublime.

didopen
I didn't see any open event, it needs to post 'open' for each file open on Sublime startup for example.

from refact-sublime.

Every time the user interacts with a new file refact_sessions calls load_document which sends a didOpen event. It even handles temporary unnamed files.

from refact-sublime.

@olegklimov is the issue that the plugin only provides open messages for files after the user interacts with them? Do you want the plugin to send didOpen messages on launch as well?

from refact-sublime.

I've tested quickly again, it's true "changed" arrives when I edit the code:

changed ...rc/vecdb/vectorizer_service.rs, total time 83.583µs

But I don't see "opened" whatever I do.

on launch as well

Sure.

from refact-sublime.

workspaces -- doesn't work, workspace_folders always empty list []
didOpen -- doesn't work (at start, clicking in a file the tree, Ctrl+O -- all three ways to open a file don't produce the message)
didChange -- ✅ works
didSave -- ✅ works
didClone -- ✅ works

from refact-sublime.

@olegklimov how do you want workspaces to work here? Are you sure didOpen isn't working I can see it's sending the message to the server and it's using the same mechanism as the ones that are working.

from refact-sublime.

workspaces

You can open a folder in Sublime, a new window opens, and all the tools like search work for all the files in that folder. So that's a good candidate for a workspace dir, organized in a list for all open windows that have folders associated.

didOpen

I noticed that too. In Sublime console there's a message, and then it gets lost somewhere along the way. refact-lsp has no problem catching didOpen:

cat ~/.cache/refact/logs/rustbinary.2024-03-05 | grep --color "opened "

from refact-sublime.

So you only want a workspace to be created if the user directly opens a folder? I'm not sure what those opened messages are indicating? Are they showing didOpen messages being received on the server or are they showing something else entirely?

from refact-sublime.

created

reported

workspace to be created if the user directly opens a folder

or starts Sublime so all the windows are restored back as they were the previous time

showing didOpen messages being received

yes, didOpen messages sent by VSCode and received fine, demonstrating didOpen works on the server side

from refact-sublime.

Checked #16.
workspaces -- doesn't work
didOpen -- working (clicking in a file the tree, Ctrl+O)
didOpen at start - message appears when you click in the selected file

from refact-sublime.

Checked.
workspaces - work, workspace_folders shows open folders.
didOpen -- working (clicking in a file the tree, Ctrl+O)
didOpen at start - message appears when you click in the selected file (In VS Code message appears when you click on the title of the selected file)

from refact-sublime.