Dropping AsyncCore in the logger thread will cause panic about async HOT 5 CLOSED

I can't think of any good excuse not to include such "fix". Can you fill a PR? In the meantime I'll think about it a little.

from async.

Yeah. Don't do it. 😁

What are you trying to do exactly? :D

from async.

@dpc As shown in the example there is a global logger for code simplicity.

There is also panic hook is to capture any uncaught panics into the log file before killing the process. During the time between flushing and log and exiting, there might still be some additional logs coming from other threads. We do not want to lose them, and therefore replaced the global logger with the one that logs to stderr.

And that turns out to cause EDEADLK when the panicking thread is the logger thread 🙃.

I'm checking if this issue is the expected behavior before changing the drainer implementation.

from async.

Global logger behind a mutex? Oh dear.

Well, dropping AsyncCore will make it wait for the the worker thread to finish ... but how is it going to finish if it's the thread that is waiting? :D

from async.

https://docs.rs/slog-async/2.3.0/src/slog_async/lib.rs.html#493

from async.