Code Monkey home page Code Monkey logo

Comments (12)

ihnorton avatar ihnorton commented on September 24, 2024

Notes from 20160916 lab meeting (cc @spujol)

General

  • Mechanism to offer "Install meta-extension" under Modules->Diffusion menu category might be sufficient for discoverability/ease-of-installation. (also useful for other groups with meta-extensions)

Tensor Estimation

  • [Weighted] Least Squares selector
    • move LS/WLS to advanced
    • check on WLS reliability and possibly make default (previously Teem issues?)

DT Scalar Maps

  • "Output Volume" include name of scalar automatically
  • Add spaces between words in the (displayed) measurement types?
    • not possible to specify separate label text for enumerations
  • move FA -> first in list

Tractography Seeding / ROI Seeding

  • Intx Seeding w/ labelmap only works with "use Index Space"
  • clarify fiducial vs labelmap seeding interaction (branch: ihn/intx_gui_update)
  • unify measure selector (Linear Measure vs FA) and start/stop threshold sliders move -> seeding options
    • add switch under UseStartingThreshold in vtkSeedTracts.cxx
  • ROI: Index Space, Spacing, "use Random grid" -> Advanced
  • Remove "Multiple File Output" option from CLI
  • "mm" displayed in Intx seeding vs "(mm)" in label in ROI (probably can't set measure units in CLI).
  • remove "Path" from "Min Path Length"
  • "Inter C tive" typo

from slicerdmri.

ihnorton avatar ihnorton commented on September 24, 2024

Proposed GUI panel update in TractographySeeding
(branch https://github.com/ihnorton/SlicerDMRI/tree/intx_gui_update)

Labelmap Fiberbundle
image image

from slicerdmri.

ljod avatar ljod commented on September 24, 2024

Looks generally good. The labelmap one seems to have more inputs than a labelmap. Does that work?

I'm not sure what the exclamation point under labelmap or the parameters node under fiber bundle mean.

If FA is for starting and stopping, should it be called stopping criteria? Perhaps just "anisotropy measure" then "seeding threshold" and "stopping threshold"

I think integration step length should move to advanced.

from slicerdmri.

ihnorton avatar ihnorton commented on September 24, 2024

The labelmap one seems to have more inputs than a labelmap. Does that work?

Not sure I follow, the sliders mostly work the same, except for the start threshold.

I wonder if we should unify "Seed Spacing" and "Fiducial Seeding Step Size" and move that to Advanced?

from slicerdmri.

ljod avatar ljod commented on September 24, 2024

the left one says select a markups fiducial but I thought it was the labelmap ROI seeding CLI. I thought that did not work with fiducials. I don't understand why the two modules have the same inputs.

I think the left one, the ROIseeding CLI, should default to index space, i.e. one seed per voxel. Please confirm this is what index space means in the code. Increasing the amount of seeding may be commonly needed, though, so I am not sure if it should be in advanced.

I don't know what the fiducial seeding step size is. Is it the seed spacing or is it the tract step size?

also integration step length should be called "Step Size" instead, and the tooltip could incorporate the old name

from slicerdmri.

ljod avatar ljod commented on September 24, 2024

Also, if seeding from a model I don't understand how the fiducial-related parameters apply. Is every model point seeded?

from slicerdmri.

ihnorton avatar ihnorton commented on September 24, 2024

the left one says select a markups fiducial but I thought it was the labelmap ROI seeding CLI. I thought that did not work with fiducials. I don't understand why the two modules have the same inputs.

It's one module, the middle (light gray background) panel changes contents depending on whether a labelmap or FB is selected. It says "Markups Fiducial" because that is the first node type that the selector is configured to accept, and I didn't have a labelmap selected.

Will double-check on the other ?s.

from slicerdmri.

ljod avatar ljod commented on September 24, 2024

I still don't get it. I thought there were two different modules?

from slicerdmri.

ihnorton avatar ihnorton commented on September 24, 2024

I updated the screenshots to show the whole panel with a labelmap selected (left), and a fiberbundle selected (right). Does that help? This is only the "Tractography Seeding" (TractographyInteractiveSeeding) module, just with two different inputs selected.

from slicerdmri.

ljod avatar ljod commented on September 24, 2024

Oh I had thought this was about unifying the interface between the interactive and CLI modules, which I had thought was the main goal.

SO we work on this one first then unify the CLI information with it for clarity. OK.

A first pass changing the label names as I suggested above will help.

Are you also trying to unify across inputs, so model vs fiducial vs labelmap? Is that the goal here?

from slicerdmri.

ihnorton avatar ihnorton commented on September 24, 2024

Are you also trying to unify across inputs, so model vs fiducial vs labelmap? Is that the goal here?

Yes. For as many common settings as possible -- moving to either "Tractography Parameters" or Advanced.

from slicerdmri.

ihnorton avatar ihnorton commented on September 24, 2024

Are you also trying to unify across inputs, so model vs fiducial vs labelmap? Is that the goal here?

I did some of the input label unifications in previous commits.

from slicerdmri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.