DiffusionTensorDisplayPropertiesNode does not serialize correctly about slicerdmri HOT 8 CLOSED

Also happens in a clean scene where few FB nodes were imported directly:

ERROR opening colour file /Users/inorton/work/test_fb/atlasconnectome/NEWclustering_k1200_30000fiber/iteration_00009/initial_clusters/DiffusionTensorDisplayProperties_1197.ctbl

from slicerdmri.

Is there some way we can avoid needing to save these color tables? Having so many of them would be extremely annoying for all users especially me.

from slicerdmri.

It looks like the extra storage nodes are created on saving of the SceneView node. It does this to prevent some other issues related to restoring Scene Views. I would need to dig deeper to figure out how to fix this without breaking other functionality. It may take couple more days, do you want me to spend this time? Also, I would suggest to keep track of slicer issues in the Mantis so we can reference other issues there.

from slicerdmri.

Hi Lauren, do you remember why you made vtkMRMLDiffusionTensorDisplayPropertiesNode a subclass of vtkMRMLColorTableNode? Does it need to be that? If we change this it will not try to save it into a file. I tacked the original problem to changes made by Nicole in vtkMRMLSceneViewNode in rev 24377, I am discussing the issue with her, but it i related to other bugs, and the easiest way to fix would be not dervie vtkMRMLDiffusionTensorDisplayPropertiesNode from vtkMRMLColorTableNode

from slicerdmri.

Isaiah do you know why? Is there dti specific stuff in it?

Lauren

from slicerdmri.

There is a comment about why at the beginning of the header (vtkMRMLDiffusionTensorDisplayPropertiesNode.h):

 32 /// This class inherits from the vtkMRMLColorNode->vtkMRMLColorTableNode superclasses,
 33 /// used for vtkMRMLModelNodes and vtkMRMLVolumeNodes, in order to
 34 /// provide specific lookup tables for the scalar invariant display.

However, such functionality was not implemented as far as I can tell:

493   /// TO DO: add specific lookup tables ranging from 0..1 for or -1 1
494   /// for scalar invariants with those ranges

So I think changing the parent is fine.

On the other hand, the easiest fix is to override vtkMRMLColorTableNode::CreateDefaultStorageNode to return NULL, which will prevent storage node generation when saving the scene. (Old scenes with the ColorStorageNode items would still print the errors, but I don't know if that can be avoided in any case)

from slicerdmri.

Submitted a slicer bug:
http://na-mic.org/Bug/view.php?id=4190

from slicerdmri.

Fixed using Isaiah's suggestion: Set default storage node for vtkMRMLDiffusionTensorDisplayPropertiesNode to NULL since it does not need to store any data in a separate file.
At revision: 25067

from slicerdmri.