macOS kernel needs to use real application name about slicerjupyter HOT 7 CLOSED

Fixed by #10 (confirmed in 20180729 nightly on Mac)

from slicerjupyter.

The kernel ends up trying to run

['', '--no-splash', '--python-code', "connection_file=r'/Users/inorton/Library/Jupyter/runtime/kernel-960845b2-8cc5-4253-a6cd-0f2cf97a829d.json'; print('Jupyter connection file: ['+connection_file+']'); slicer.modules.jupyterkernel.startKernel(connection_file);slicer.util.mainWindow().showMinimized()"]

which fails.

from slicerjupyter.

This would be nice to fix anyway - currently Slicer's process name shows up empty in macos utilities like Activity Monitor. It's never been a real issue before but it's annoying.

from slicerjupyter.

I don't have a Mac, so I cannot fix this. Can you try if replacing app->launcherExecutableFilePath() by slicer.app.applicationFilePath() in qSlicerJupyterKernelModule.cxx fixes the problem?

from slicerjupyter.

currently Slicer's process name shows up empty in macos utilities like Activity Monitor

@pieper What this a general comment or is it specific to SlicerJupyer ?

app->launcherExecutableFilePath() by slicer.app.applicationFilePath() in qSlicerJupyterKernelModule.cxx

👍

from slicerjupyter.

@pieper What this a general comment or is it specific to SlicerJupyer ?

It looked to me like the same underlying issue - if you fix the application name for SlicerJupyter then it should also fix the issue in the Activity Monitor (and in Force Quit). But maybe that's not the case if this code is only relying on the launcher.

from slicerjupyter.

fix the issue in the Activity Monito

Problem identified, fix on the way.

from slicerjupyter.